Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes for windows high contrast buttons #2826

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

cRui861
Copy link
Member

@cRui861 cRui861 commented Oct 27, 2023

Fixes AB#1051, AB#1059, and AB#1060

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2826 (cd9c15a) into main (e4c00c1) will not change coverage.
The diff coverage is n/a.

❗ Current head cd9c15a differs from pull request most recent head 7dfe3e2. Consider uploading reports for the commit 7dfe3e2 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2826   +/-   ##
=======================================
  Coverage   66.56%   66.56%           
=======================================
  Files        1245     1245           
  Lines       34122    34122           
  Branches     6220     6220           
=======================================
  Hits        22714    22714           
  Misses      11272    11272           
  Partials      136      136           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c00c1...7dfe3e2. Read the comment docs.

@cRui861 cRui861 merged commit 8de3de2 into main Oct 30, 2023
6 checks passed
@cRui861 cRui861 deleted the rechen/a11y branch October 30, 2023 23:53
@cRui861
Copy link
Member Author

cRui861 commented Nov 8, 2023

Fixes #2835

gingi pushed a commit that referenced this pull request Nov 9, 2023
* AB#1060 general fix for disabled buttons in windows high contrast mode

* AB#1051 narrator will read aloud favorites dropdown options now

---------

Co-authored-by: Rena Chen <rechen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants