Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabSelector form control #2827

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add TabSelector form control #2827

merged 1 commit into from
Nov 2, 2023

Conversation

dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Oct 31, 2023

Screenshot:

Screenshot 2023-10-31 at 3 53 47 PM

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2827 (95428c2) into main (f6ad839) will decrease coverage by 0.03%.
The diff coverage is 58.69%.

❗ Current head 95428c2 differs from pull request most recent head 6c6f4f0. Consider uploading reports for the commit 6c6f4f0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2827      +/-   ##
==========================================
- Coverage   66.72%   66.70%   -0.03%     
==========================================
  Files        1245     1247       +2     
  Lines       34135    34226      +91     
  Branches     6174     6239      +65     
==========================================
+ Hits        22778    22830      +52     
- Misses      11221    11254      +33     
- Partials      136      142       +6     
Files Coverage Δ
packages/bonito-core/src/form/parameter.ts 86.73% <100.00%> (+0.27%) ⬆️
packages/bonito-ui/src/components/form/index.ts 100.00% <100.00%> (ø)
...kages/bonito-ui/src/components/form/text-field.tsx 83.87% <100.00%> (+2.38%) ⬆️
packages/bonito-ui/src/form/react-form.ts 100.00% <100.00%> (ø)
packages/playground/src/layout/demo-nav-menu.tsx 100.00% <ø> (ø)
packages/playground/src/demo-routes.tsx 56.09% <50.00%> (-0.32%) ⬇️
...ages/playground/src/demo/form/action-form-demo.tsx 17.33% <25.00%> (-0.73%) ⬇️
...ges/playground/src/demo/form/tab-selector-demo.tsx 39.13% <39.13%> (ø)
...ges/bonito-ui/src/components/form/tab-selector.tsx 62.96% <62.96%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ad839...6c6f4f0. Read the comment docs.

@dpwatrous dpwatrous merged commit 7ea11e2 into main Nov 2, 2023
6 checks passed
@dpwatrous dpwatrous deleted the dpwatrous/tab-selector branch November 2, 2023 19:41
gingi pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants