Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requiredSlots disable logic for multi-instance tasks #2860

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

wanghoppe
Copy link
Member

@wanghoppe wanghoppe commented Dec 19, 2023

image

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (3384491) 67.29% compared to head (c970c0d) 67.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   67.29%   67.27%   -0.03%     
==========================================
  Files        1228     1228              
  Lines       33604    33618      +14     
  Branches     6206     6158      -48     
==========================================
  Hits        22615    22615              
- Misses      10842    10856      +14     
  Partials      147      147              
Files Coverage Δ
desktop/src/app/models/forms/create-task-model.ts 0.00% <0.00%> (ø)
...ponents/task/action/add/add-task-form.component.ts 14.75% <0.00%> (-3.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3384491...c970c0d. Read the comment docs.

@dpwatrous
Copy link
Member

Looks like the CI failed because you need to run a build and check in the translation string files.

@wanghoppe wanghoppe merged commit f36d6a8 into main Dec 20, 2023
8 checks passed
@wanghoppe wanghoppe deleted the hoppe/requiredSlot branch December 20, 2023 15:46
@cRui861
Copy link
Member

cRui861 commented Jan 9, 2024

Fixes #2876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants