[iOS] ACSRendererView Issues when joining a call with a reused groupId

[ryanespiritu]

Describe the bug
When joining a call with a groupId that was previously used, the ACSRendererView for a remote participant that was also previously in the call will be blank.

To Reproduce
Steps to reproduce the behavior:

1. On two separate devices, join a call using a given groupId (make sure you join with video)
2. Create ACSRendererViews for each participant and add them to the view hierarchy
3. Remove ACSRendererViews from the view hierarchy, dispose their respective renderers, and hang up the call on both devices
4. Repeat steps 1-2
5. Observe: That the ACSRendererView will be blank for remote participants

Expected behavior
The ACSRendererViews should be rendered properly.

Smartphone (please complete the following information):

• Devices: iPhone X iOS14.1, iPhone 11 Pro iOS13.2.3

[mariusu-msft]

This is an odd issue, since if you hangup on 3) it's considered a new call when you do 4.

@sankum-msft can you investigate please?

[terrychen1122]

@mariusu-msft by "old issue", did you mean this is a known issue to the team?

[mariusu-msft]

@terrychen1122 "odd" issue.

This is not expected, between two call instances there's nothing being reused internally in respect of video stream state.

@sankum-msft will be investigating next week

[sankum-msft]

Hi @terrychen1122, I was not able to repro this issue using iPhone XS or simulator.

From the description, it seems like the Renderer wasn't disposed off properly. Please note that you need to dispose Renderers for both incoming video and preview of local video, if you have one. After hangup, if you still see the green dot in iPhone's status bar (which indicates camera is in use), that would mean that the Renderer corresponding to LocalVideoStream was not disposed.

If the above is not helpful in your case, please share logs from your device. You can follow this guide to collect logs.

[ryanespiritu]

Hi @sankum-msft, thank you for your response. I just double checked and we are indeed disposing both the local and remote participant video renderers upon hangup of a call. The green dot also disappears once we exit the call.

I wasn't sure which .blog file would be the most helpful, so I've attached all of the ones in my app container:
ACS_logs.zip

[sankum-msft]

In your app, you are sharing a LocalVideoStream object between multiple calls. There is a bug in LocalVideoStream where it doesn't start properly in this re-use case. I've opened an internal bug ( AB#2325309 ) to get this fixed. For now, workaround is to create/destroy LocalVideoStream when you start/end a call.

Please confirm that the workaround works for you.

[ryanespiritu]

Hi @sankum-msft thanks for your help, I've verified that this workaround fixes the issue for us

[sankum-msft]

Fix has been merged for this issue and will be included in the next release.

[sankum-msft]

Closing this issue as the fix is included in 1.0.0-beta.8 release of the ACS iOS SDK. Please re-open if issue persists for you after the upgrade.