Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] ACSRendererView layout is off after a device rotation #127

Closed
ryanespiritu opened this issue Nov 30, 2020 · 5 comments
Closed

[iOS] ACSRendererView layout is off after a device rotation #127

ryanespiritu opened this issue Nov 30, 2020 · 5 comments
Assignees
Labels
ADO Linked This issue has an ADO Item on our ADO. Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK Video

Comments

@ryanespiritu
Copy link

ryanespiritu commented Nov 30, 2020

Describe the bug
Using autolayout to update the constraints of an ACSRendererView after a device rotation seems to update the frame correctly (verified this by checking to see if the height and width values were what I expected). However, visually, the ACSRendererView is not adhering to the new frame/constraint values; it overflows and looks off after a device rotation.

To Reproduce
Steps to reproduce the behavior:

  1. Add ACSRendererView to view hierarchy and set constraints via autolayout
  2. Rotate device/simulator
  3. Observe that the frame is updated correctly by the autolayout constraints you set, but the visual appearance of the view is not reflecting the updated frame

Expected behavior
After a rotation, the updated frame values of the ACSRendererView should be accurately reflected in the visual appearance of the view.

EDIT: attaching a video for reference of the issue

ACSRendererView

@ghost ghost added the Needs: triage 🔍 label Nov 30, 2020
@terrychen1122
Copy link

From my testing, this issue also exists with manually changing the frame when rotation happened (regardless auto-layout)

@sankum-msft
Copy link
Contributor

sankum-msft commented Dec 1, 2020

Thanks for reporting the issue @terrychen1122 !

I was able to repro this in a more general form - resizing RendererView doesn't actually resize/reposition the drawing area. I have opened a bug (AB#2325318) on our board to get this fixed.

@ghost ghost added the ADO Linked This issue has an ADO Item on our ADO. label Dec 1, 2020
@RinaRish RinaRish added Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK and removed Needs: triage 🔍 labels Dec 2, 2020
@sankum-msft
Copy link
Contributor

Fix has been merged for this issue and will be included in the next release.

@sankum-msft
Copy link
Contributor

Closing this issue as the fix is included in 1.0.0-beta.8 release of the ACS iOS SDK. Please re-open if issue persists for you after the upgrade.

@ryanespiritu
Copy link
Author

Hey @sankum-msft, after bumping to the latest release the issue is fixed for physical devices but I still see some layout issues on simulator.

Looks like the ACSRenderView's frame is correct but the frame of the inner "gif" is off. See attached video:

acsrendererview_landscape.mov

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ADO Linked This issue has an ADO Item on our ADO. Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK Video
Projects
None yet
Development

No branches or pull requests

4 participants