Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Added instructions for adding Easy Auth to an existing cluster. #66

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Added instructions for adding Easy Auth to an existing cluster. #66

merged 4 commits into from
Feb 3, 2022

Conversation

danielkon96
Copy link
Contributor

No description provided.

@danielkon96 danielkon96 added this to In progress in EasyAuthForK8s Roadmap via automation Feb 2, 2022
@danielkon96 danielkon96 added the documentation Improvements or additions to documentation label Feb 2, 2022
@danielkon96 danielkon96 linked an issue Feb 2, 2022 that may be closed by this pull request
Document deploying proxy to existing application #52
Closed
@jonlester jonlester merged commit 2b74087 into master Feb 3, 2022
EasyAuthForK8s Roadmap automation moved this from In progress to Done Feb 3, 2022
lastcoolnameleft
lastcoolnameleft reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@lastcoolnameleft lastcoolnameleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the "docs/media/with-easyauth.png" accurately describes the scenario. The request doesn't go from Easy-Auth Proxy to the Pod. Instead nginx makes a side request to EAK and if it passes, then the req continues onto the existing pod.

See:
https://github.com/Azure/EasyAuthForK8s/blob/master/docs/media/basic-flow.jpg

@danielkon96
Copy link
Contributor Author

I don't believe the "docs/media/with-easyauth.png" accurately describes the scenario. The request doesn't go from Easy-Auth Proxy to the Pod. Instead nginx makes a side request to EAK and if it passes, then the req continues onto the existing pod.

See: https://github.com/Azure/EasyAuthForK8s/blob/master/docs/media/basic-flow.jpg

See the latest PR #69 . Fixed!

@lastcoolnameleft
Copy link
Contributor

Looks good. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lastcoolnameleft lastcoolnameleft lastcoolnameleft left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
EasyAuthForK8s Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document deploying proxy to existing application
3 participants
@danielkon96 @lastcoolnameleft @jonlester