Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal update Private DNS Zone enablement to include a dropdown of services #1505

Merged
merged 52 commits into from
Jan 7, 2024

Conversation

rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Dec 14, 2023

Overview/Summary

This PR is adding selection option for Azure Private DNS Zones as part of portal based ALZ deployment experience where you can select to deploy or not to deploy a subset of DNS zones.

This PR fixes/adds/changes/removes

  1. Updated eslzArm.json and eslz-portal.json
  2. Update portal RI

Breaking Changes

  1. N/A

Testing Evidence

Ekran görüntüsü 2023-12-14 111929
Ekran görüntüsü 2023-12-14 111946
Ekran görüntüsü 2023-12-14 115918

Ekran görüntüsü 2023-12-14 114226

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93
Copy link
Contributor

Have fixed the comments I raised and tested:
image
image

@jtracey93 jtracey93 merged commit d02f904 into Azure:main Jan 7, 2024
3 of 4 checks passed
@rozkurt rozkurt deleted the PortalUpdate_PrivateDNSZoneEnablement branch March 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants