Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TF Sync Param File to align to portal defaults #1686

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Update TF Sync Param File to align to portal defaults #1686

merged 2 commits into from
Jun 20, 2024

Conversation

jtracey93
Copy link
Contributor

Overview/Summary

Update TF Sync Param File to align to portal defaults

This PR fixes/adds/changes/removes

  1. Update TF Sync Param File to align to portal defaults

Breaking Changes

None

Testing Evidence

N/A

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 requested a review from a team as a code owner June 20, 2024 09:05
@jaredfholgate
Copy link
Member

@jtracey93 This one is difficult to review by eye, running an update against this branch to see the diff. Will report back.

@jaredfholgate
Copy link
Member

@jtracey93 Here we go: https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pull/1005/files

jaredfholgate
jaredfholgate approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgtm Tested over here: https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pull/1005/files

@jtracey93 jtracey93 closed this Jun 20, 2024
@jtracey93 jtracey93 reopened this Jun 20, 2024
@jtracey93 jtracey93 merged commit 16afa92 into main Jun 20, 2024
3 of 4 checks passed
@jtracey93 jtracey93 deleted the users/jtracey93/update-tf-sync-params branch June 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtracey93 @jaredfholgate