Avoid NullReferenceException in case of job continuation #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcschier
approved these changes
Oct 23, 2020
barnstee
reviewed
Oct 23, 2020
| @@ -235,6 +237,8 @@ public class Worker : IWorker, IDisposable { | |||
|
|
|||
| // Check if the job is to be continued with new configuration settings | |||
| if (_jobProcess.JobContinuation == null) { | |||
| _jobProcess.Status = WorkerStatus.Stopped; | |||
monikavar
pushed a commit
that referenced
this pull request
May 6, 2021
monikavar
pushed a commit
that referenced
this pull request
May 7, 2021
marcschier
added a commit
that referenced
this pull request
May 12, 2021
* Avoid NullReferenceException in case of job continuation (#819) * WorkerSupervisor enable the reduction of Worker (#751) Worker supervisor should also stop worker if max number of worker has decreased * Removed not used methods from IWorkerSupervisor interface * Added observability property, to read number of workers from test * Added tests for WorkerSupervisor * [Refactoring] change accessibility to private for methods CreateWorker and StopWorker * Extend WorkerSupervisor tests and logging when redusing MaxWorker * Set WorkerSupervisor interval via optional parameter to optimize testing Co-authored-by: Alexander Köpke <koepalex@xdigital.de> Co-authored-by: Marc Schier <marcschier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: there are multiple places were the JobProcessor is set to null. Which can lead to NullReferenceException in Cancel method e.g. when job continuation is triggered.
Solution: Check for null in Cancel method and update worker status on every place were it set to null to have the information in cosmosdb in sync.