feat(designer): make adjustments to http request trigger parameters t…

…o make chosen method clearer (#4398)
Azure · Mar 21, 2024 · 261511d · 261511d
1 parent 45b56ce
commit 261511d
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 52 deletions.
diff --git a/Localize/lang/strings.json b/Localize/lang/strings.json
@@ -1925,7 +1925,6 @@
   "_fKYuwf.comment": "Placeholder description for a newly inserted File parameter",
   "_fVG5aD.comment": "Time zone value ",
   "_faUrud.comment": "Message to show under the loading icon when loading connection parameters",
-  "_fc1AV8.comment": "Callback url method",
   "_fg/34o.comment": "Label for logical functions",
   "_fifSPb.comment": "Time zone value ",
   "_fmm7Ik.comment": "Token picker mode to insert expressions",
@@ -2555,7 +2554,6 @@
   "fKYuwf": "Please select file or image",
   "fVG5aD": "(UTC-05:00) Haiti",
   "faUrud": "Loading connection data...",
-  "fc1AV8": "HTTP {method} URL",
   "fg/34o": "Logical functions",
   "fifSPb": "(UTC-03:30) Newfoundland",
   "fmm7Ik": "Function",

diff --git a/libs/designer/src/lib/core/actions/bjsworkflow/initialize.ts b/libs/designer/src/lib/core/actions/bjsworkflow/initialize.ts
@@ -54,7 +54,6 @@ import {
   equals,
   getBrandColorFromConnector,
   getIconUriFromConnector,
-  getIntl,
   getObjectPropertyValue,
   isDynamicListExtension,
   isDynamicPropertiesExtension,
@@ -435,12 +434,7 @@ export const updateCallbackUrlInInputs = async (
       const callbackInfo = await WorkflowService().getCallbackUrl(nodeId);
       const parameter = getParameterFromName(nodeInputs, 'callbackUrl');
 
-      const intl = getIntl();
       if (parameter && callbackInfo) {
-        parameter.label = intl.formatMessage(
-          { defaultMessage: 'HTTP {method} URL', id: 'fc1AV8', description: 'Callback url method' },
-          { method: callbackInfo.method }
-        );
         parameter.value = [createLiteralValueSegment(callbackInfo.value)];
 
         return parameter;

diff --git a/libs/services/designer-client-services/src/lib/base/manifests/request.ts b/libs/services/designer-client-services/src/lib/base/manifests/request.ts
@@ -22,20 +22,18 @@ export default {
             skip: true,
           },
         },
-        schema: {
-          type: 'object',
-          title: 'Request Body JSON Schema',
-          description:
-            'Example:\n{\n    "type": "object",\n    "properties": {\n        "address": {\n            "type": "string"\n        }\n    },\n    "required": ["address"]\n}',
-          'x-ms-editor': 'schema',
-          'x-ms-visiblity': 'important',
-        },
         method: {
           type: 'string',
           title: 'Method',
+          'x-ms-visiblity': 'important',
           'x-ms-editor': 'combobox',
+          description: 'URL will be generated after save',
           'x-ms-editor-options': {
             options: [
+              {
+                displayName: 'Default (Allow All Methods)',
+                value: '',
+              },
               {
                 displayName: 'GET',
                 value: 'GET',
@@ -59,6 +57,14 @@ export default {
             ],
           },
         },
+        schema: {
+          type: 'object',
+          title: 'Request Body JSON Schema',
+          description:
+            'Example:\n{\n    "type": "object",\n    "properties": {\n        "address": {\n            "type": "string"\n        }\n    },\n    "required": ["address"]\n}',
+          'x-ms-editor': 'schema',
+          'x-ms-visiblity': 'important',
+        },
         relativePath: {
           type: 'string',
           title: 'Relative path',

diff --git a/libs/services/intl/src/compiled-lang/strings.en-XA.json b/libs/services/intl/src/compiled-lang/strings.en-XA.json
@@ -14973,28 +14973,6 @@
       "value": "]"
     }
   ],
-  "fc1AV8": [
-    {
-      "type": 0,
-      "value": "["
-    },
-    {
-      "type": 0,
-      "value": "ĦŦŦƤ "
-    },
-    {
-      "type": 1,
-      "value": "method"
-    },
-    {
-      "type": 0,
-      "value": " ŬŘĿ"
-    },
-    {
-      "type": 0,
-      "value": "]"
-    }
-  ],
   "fg/34o": [
     {
       "type": 0,

diff --git a/libs/services/intl/src/compiled-lang/strings.json b/libs/services/intl/src/compiled-lang/strings.json
@@ -6805,20 +6805,6 @@
       "value": "Loading connection data..."
     }
   ],
-  "fc1AV8": [
-    {
-      "type": 0,
-      "value": "HTTP "
-    },
-    {
-      "type": 1,
-      "value": "method"
-    },
-    {
-      "type": 0,
-      "value": " URL"
-    }
-  ],
   "fg/34o": [
     {
       "type": 0,