fix(designer): Fix linter errors happening on PRs from library consol…

…odation (#4315)

apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerBase.ts

@@ -5,8 +5,7 @@
 import { tryGetWebviewPanel } from '../../../utils/codeless/common';
 import { getWebViewHTML } from '../../../utils/codeless/getWebViewHTML';
 import type { IAzureConnectorsContext } from '../azureConnectorWizard';
-import { ResolutionService } from '@microsoft/logic-apps-shared';
-import { isEmptyString } from '@microsoft/logic-apps-shared';
+import { ResolutionService, isEmptyString } from '@microsoft/logic-apps-shared';
 import type { IActionContext } from '@microsoft/vscode-azext-utils';
 import type { Artifacts, AzureConnectorDetails, ConnectionsData, FileDetails, Parameter } from '@microsoft/vscode-extension';
 import type { WebviewPanel, WebviewOptions, WebviewPanelOptions } from 'vscode';

libs/data-mapper/src/lib/core/DataMapperDesignerProvider.tsx

@@ -9,8 +9,7 @@ import type { Theme } from '@fluentui/react-components';
 import { FluentProvider, themeToTokensObject, webDarkTheme, webLightTheme } from '@fluentui/react-components';
 import { PortalCompatProvider } from '@fluentui/react-portal-compat';
 import { AppInsightsContext } from '@microsoft/applicationinsights-react-js';
-import { IntlProvider } from '@microsoft/logic-apps-shared';
-import { Theme as ThemeType } from '@microsoft/logic-apps-shared';
+import { IntlProvider, Theme as ThemeType } from '@microsoft/logic-apps-shared';
 import React from 'react';
 import { QueryClient, QueryClientProvider } from 'react-query';
 import { Provider as ReduxProvider } from 'react-redux';

libs/designer-ui/src/lib/authentication/MSIAuth/MSIAuth.tsx

@@ -7,9 +7,8 @@ import { AuthenticationProperty } from '../AuthenticationProperty';
 import { AUTHENTICATION_PROPERTIES, containsUserAssignedIdentities } from '../util';
 import { MSIAuthenticationDefault } from './MSIAuthDefault';
 import type { IDropdownOption } from '@fluentui/react';
-import { isTemplateExpression } from '@microsoft/logic-apps-shared';
+import { isTemplateExpression, ResourceIdentityType, equals } from '@microsoft/logic-apps-shared';
 import type { ManagedIdentity } from '@microsoft/logic-apps-shared';
-import { ResourceIdentityType, equals } from '@microsoft/logic-apps-shared';
 import type { Dispatch, SetStateAction } from 'react';
 import { useState } from 'react';
 import type { IntlShape } from 'react-intl';

libs/designer-ui/src/lib/authentication/index.tsx

@@ -12,9 +12,8 @@ import { MSIAuthentication } from './MSIAuth/MSIAuth';
 import { RawAuthentication } from './RawAuth';
 import { parseAuthEditor } from './util';
 import type { IDropdownOption } from '@fluentui/react/lib/Dropdown';
-import { getIntl } from '@microsoft/logic-apps-shared';
+import { getIntl, AssertionErrorCode, AssertionException, format } from '@microsoft/logic-apps-shared';
 import type { ManagedIdentity } from '@microsoft/logic-apps-shared';
-import { AssertionErrorCode, AssertionException, format } from '@microsoft/logic-apps-shared';
 import { useUpdateEffect } from '@react-hookz/web';
 import { useState } from 'react';
 import { useIntl } from 'react-intl';

libs/designer-ui/src/lib/authentication/util.ts

@@ -6,9 +6,8 @@ import { ValueSegmentType } from '../editor';
 import { convertStringToSegments } from '../editor/base/utils/editorToSegment';
 import { convertKeyValueItemToSegments } from '../editor/base/utils/keyvalueitem';
 import { AuthenticationOAuthType } from './AADOAuth/AADOAuth';
-import { getIntl } from '@microsoft/logic-apps-shared';
+import { getIntl, guid, equals, ResourceIdentityType } from '@microsoft/logic-apps-shared';
 import type { ManagedIdentity } from '@microsoft/logic-apps-shared';
-import { guid, equals, ResourceIdentityType } from '@microsoft/logic-apps-shared';
 
 export interface AuthProperty {
   displayName: string;

libs/designer-ui/src/lib/code/util.ts

@@ -1,9 +1,16 @@
 import constants from '../constants';
 import type { Token, ValueSegment } from '../editor';
 import { TokenType } from '../editor';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { decodePropertySegment, OutputKeys } from '@microsoft/logic-apps-shared';
-import { ArgumentException, endsWith, equals, prettifyJsonString, UnsupportedException } from '@microsoft/logic-apps-shared';
+import {
+  getIntl,
+  decodePropertySegment,
+  OutputKeys,
+  ArgumentException,
+  endsWith,
+  equals,
+  prettifyJsonString,
+  UnsupportedException,
+} from '@microsoft/logic-apps-shared';
 
 const OperationCategory = {
   Actions: 'actions',

libs/designer-ui/src/lib/combobox/index.tsx

@@ -7,8 +7,7 @@ import type { IComboBox, IComboBoxOption, IComboBoxOptionStyles, IComboBoxStyles
 import { SelectableOptionMenuItemType, ComboBox } from '@fluentui/react';
 import { Button, Spinner, Tooltip } from '@fluentui/react-components';
 import { bundleIcon, Dismiss24Filled, Dismiss24Regular } from '@fluentui/react-icons';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { guid } from '@microsoft/logic-apps-shared';
+import { getIntl, guid } from '@microsoft/logic-apps-shared';
 import { useRef, useState, useCallback, useMemo, useEffect } from 'react';
 import type { FormEvent } from 'react';
 import { useIntl } from 'react-intl';

libs/designer-ui/src/lib/dynamicallyaddedparameter/helper.ts

@@ -1,7 +1,6 @@
 import type { DynamicallyAddedParameterTypeType } from '../dynamicallyaddedparameter';
 import { DynamicallyAddedParameterType } from '../dynamicallyaddedparameter';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { generateUniqueName } from '@microsoft/logic-apps-shared';
+import { getIntl, generateUniqueName } from '@microsoft/logic-apps-shared';
 
 export type DynamicallyAddedParameterIcon = string;
 

libs/designer-ui/src/lib/editor/base/utils/keyvalueitem.ts

@@ -3,8 +3,7 @@ import { isEmpty } from '../../../dictionary/expandeddictionary';
 import { ValueSegmentType, type ValueSegment } from '../../models/parameter';
 import { insertQutationForStringType } from './helper';
 import { convertSegmentsToString } from './parsesegments';
-import { isNumber } from '@microsoft/logic-apps-shared';
-import { guid, isBoolean } from '@microsoft/logic-apps-shared';
+import { isNumber, guid, isBoolean } from '@microsoft/logic-apps-shared';
 
 export interface KeyValueItem {
   id: string;

libs/designer-ui/src/lib/editor/base/utils/parsesegments.ts

@@ -21,8 +21,7 @@ import { $isListNode, $isListItemNode, $createListItemNode } from '@lexical/list
 import type { HeadingNode } from '@lexical/rich-text';
 import { $isHeadingNode } from '@lexical/rich-text';
 import type { Expression } from '@microsoft/logic-apps-shared';
-import { ExpressionParser } from '@microsoft/logic-apps-shared';
-import { wrapTokenValue } from '@microsoft/logic-apps-shared';
+import { ExpressionParser, wrapTokenValue } from '@microsoft/logic-apps-shared';
 import type { LexicalNode, ParagraphNode, RootNode } from 'lexical';
 import {
   $createParagraphNode,

libs/designer-ui/src/lib/editor/models/parameter.ts

@@ -3,8 +3,9 @@ import type {
   InputDependencies,
   ParameterDeserializationOptions,
   ParameterSerializationOptions,
+  Exception,
+  OpenAPIV2,
 } from '@microsoft/logic-apps-shared';
-import type { Exception, OpenAPIV2 } from '@microsoft/logic-apps-shared';
 
 export interface ParameterInfo {
   alternativeKey?: string;

libs/designer-ui/src/lib/recurrence/preview.tsx

@@ -1,8 +1,7 @@
 import type { Recurrence } from '.';
 import constants from '../constants';
 import { getIntervalValue } from './util';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { equals, getPropertyValue } from '@microsoft/logic-apps-shared';
+import { getIntl, equals, getPropertyValue } from '@microsoft/logic-apps-shared';
 import { useIntl } from 'react-intl';
 
 interface PreviewProps {

libs/designer-ui/src/lib/staticResult/index.tsx

@@ -3,8 +3,7 @@ import { StaticResult } from './StaticResult';
 import { deserializePropertyValues, parseStaticResultSchema, serializePropertyValues } from './util';
 import type { IButtonStyles } from '@fluentui/react';
 import { DefaultButton, PrimaryButton, Toggle } from '@fluentui/react';
-import type { OpenApiSchema } from '@microsoft/logic-apps-shared';
-import type { OpenAPIV2 } from '@microsoft/logic-apps-shared';
+import type { OpenApiSchema, OpenAPIV2 } from '@microsoft/logic-apps-shared';
 import { useEffect, useMemo, useState } from 'react';
 import { useIntl } from 'react-intl';
 

libs/designer-ui/src/lib/table/index.tsx

@@ -4,8 +4,7 @@ import { ValueSegmentType } from '../editor';
 import type { ChangeState } from '../editor/base';
 import type { IDropdownOption, IDropdownStyles } from '@fluentui/react';
 import { Dropdown } from '@fluentui/react';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { guid } from '@microsoft/logic-apps-shared';
+import { getIntl, guid } from '@microsoft/logic-apps-shared';
 import type { FormEvent } from 'react';
 import { useState } from 'react';
 

libs/designer-ui/src/lib/tokenpicker/util.ts

@@ -1,7 +1,6 @@
 import type { Token } from './models/token';
 import type { Expression, ExpressionFunction, ExpressionLiteral } from '@microsoft/logic-apps-shared';
-import { ExpressionType } from '@microsoft/logic-apps-shared';
-import { UnsupportedException } from '@microsoft/logic-apps-shared';
+import { ExpressionType, UnsupportedException } from '@microsoft/logic-apps-shared';
 
 export function getExpressionTokenTitle(expression: Expression): string {
   switch (expression.type) {

libs/designer-ui/src/lib/utils/utils.ts

@@ -1,6 +1,5 @@
 import Constants from '../constants';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { equals, isBuiltInConnector, isCustomConnector } from '@microsoft/logic-apps-shared';
+import { getIntl, equals, isBuiltInConnector, isCustomConnector } from '@microsoft/logic-apps-shared';
 
 /**
  * Returns a string with a duration, possibly abbreviated, e.g., 15s or 15 second(s)

libs/designer-ui/src/lib/workflow/languageservice/workflowlanguageservice.ts

@@ -2,9 +2,8 @@ import Constants from '../../constants';
 import { isHighContrastBlack } from '../../utils';
 import type { FunctionDefinition, SignatureInfo } from './templatefunctions';
 import { FunctionGroupDefinitions } from './templatefunctions';
-import { ExpressionScanner, ExpressionTokenType } from '@microsoft/logic-apps-shared';
+import { ExpressionScanner, ExpressionTokenType, equals, first, getPropertyValue, map } from '@microsoft/logic-apps-shared';
 import type { ExpressionToken } from '@microsoft/logic-apps-shared';
-import { equals, first, getPropertyValue, map } from '@microsoft/logic-apps-shared';
 import type { languages, editor, Position } from 'monaco-editor';
 
 type CompletionList = languages.CompletionList;

libs/designer-ui/src/lib/workflow/schema/generator.ts

@@ -1,7 +1,6 @@
 import { InvalidJsonSchemaTypeException } from '../exceptions/invalidjsonschematype';
-import { isTemplateExpression } from '@microsoft/logic-apps-shared';
+import { isTemplateExpression, createCopy, clone } from '@microsoft/logic-apps-shared';
 import type { OpenAPIV2 } from '@microsoft/logic-apps-shared';
-import { createCopy, clone } from '@microsoft/logic-apps-shared';
 
 export const Types = {
   object: 'object',

libs/designer/src/lib/common/exceptions/exception.ts

@@ -1,6 +1,5 @@
-import { getIntl } from '@microsoft/logic-apps-shared';
+import { getIntl, isException } from '@microsoft/logic-apps-shared';
 import type { Exception } from '@microsoft/logic-apps-shared';
-import { isException } from '@microsoft/logic-apps-shared';
 
 export function includeInnerExceptionMessage(error: Error | Exception): string {
   const intl = getIntl();

libs/designer/src/lib/core/actions/bjsworkflow/__test__/connections.spec.ts

@@ -11,9 +11,8 @@ import {
   StandardOperationManifestService,
   OperationManifestService,
 } from '@microsoft/designer-client-services-logic-apps';
-import { createItem } from '@microsoft/logic-apps-shared';
+import { createItem, ConnectionReferenceKeyFormat } from '@microsoft/logic-apps-shared';
 import type { LogicAppsV2, OperationManifest } from '@microsoft/logic-apps-shared';
-import { ConnectionReferenceKeyFormat } from '@microsoft/logic-apps-shared';
 
 const nodeId = '1';
 const connectionName = 'name123';

libs/designer/src/lib/core/actions/bjsworkflow/add.ts

@@ -30,16 +30,15 @@ import type { NodeDataWithOperationMetadata } from './operationdeserializer';
 import type { Settings } from './settings';
 import { getOperationSettings, getSplitOnValue } from './settings';
 import { ConnectionService, OperationManifestService, StaticResultService } from '@microsoft/designer-client-services-logic-apps';
-import type { SwaggerParser } from '@microsoft/logic-apps-shared';
-import { ManifestParser } from '@microsoft/logic-apps-shared';
 import type {
+  SwaggerParser,
   Connector,
   DiscoveryOperation,
   DiscoveryResultTypes,
   OperationManifest,
   SomeKindOfAzureOperationDiscovery,
 } from '@microsoft/logic-apps-shared';
-import { equals, getRecordEntry } from '@microsoft/logic-apps-shared';
+import { ManifestParser, equals, getRecordEntry } from '@microsoft/logic-apps-shared';
 import type { Dispatch } from '@reduxjs/toolkit';
 import { createAsyncThunk } from '@reduxjs/toolkit';
 import { batch } from 'react-redux';

libs/designer/src/lib/core/actions/bjsworkflow/initialize.ts

@@ -47,9 +47,8 @@ import {
   ApiManagementService,
 } from '@microsoft/designer-client-services-logic-apps';
 import type { OutputToken, ParameterInfo } from '@microsoft/designer-ui';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import type { SchemaProperty, InputParameter, SwaggerParser, OutputParameter } from '@microsoft/logic-apps-shared';
 import {
+  getIntl,
   isDynamicListExtension,
   isDynamicPropertiesExtension,
   isDynamicSchemaExtension,
@@ -59,8 +58,6 @@ import {
   DynamicSchemaType,
   ManifestParser,
   PropertyName,
-} from '@microsoft/logic-apps-shared';
-import {
   CustomSwaggerServiceNames,
   UnsupportedException,
   clone,
@@ -70,6 +67,10 @@ import {
   getObjectPropertyValue,
 } from '@microsoft/logic-apps-shared';
 import type {
+  SchemaProperty,
+  InputParameter,
+  SwaggerParser,
+  OutputParameter,
   CustomSwaggerServiceDetails,
   OperationInfo,
   OperationManifest,

libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts

@@ -56,11 +56,18 @@ import {
   OperationManifestService,
   StaticResultService,
 } from '@microsoft/designer-client-services-logic-apps';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import type { InputParameter, OutputParameter } from '@microsoft/logic-apps-shared';
-import { ManifestParser } from '@microsoft/logic-apps-shared';
-import type { LogicAppsV2, OperationManifest } from '@microsoft/logic-apps-shared';
-import { isArmResourceId, uniqueArray, getPropertyValue, map, aggregate, equals, getRecordEntry } from '@microsoft/logic-apps-shared';
+import {
+  getIntl,
+  ManifestParser,
+  isArmResourceId,
+  uniqueArray,
+  getPropertyValue,
+  map,
+  aggregate,
+  equals,
+  getRecordEntry,
+} from '@microsoft/logic-apps-shared';
+import type { InputParameter, OutputParameter, LogicAppsV2, OperationManifest } from '@microsoft/logic-apps-shared';
 import type { Dispatch } from '@reduxjs/toolkit';
 
 export interface NodeDataWithOperationMetadata extends NodeData {

libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts

@@ -22,9 +22,8 @@ import type { NodeStaticResults } from './staticresults';
 import { LogEntryLevel, LoggerService, OperationManifestService, WorkflowService } from '@microsoft/designer-client-services-logic-apps';
 import type { ParameterInfo } from '@microsoft/designer-ui';
 import { UIConstants } from '@microsoft/designer-ui';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import type { Segment } from '@microsoft/logic-apps-shared';
 import {
+  getIntl,
   create,
   removeConnectionPrefix,
   cleanIndexedValue,
@@ -33,9 +32,6 @@ import {
   SegmentType,
   DeserializationType,
   PropertySerializationType,
-} from '@microsoft/logic-apps-shared';
-import type { LocationSwapMap, LogicAppsV2, OperationManifest, SubGraphDetail } from '@microsoft/logic-apps-shared';
-import {
   SerializationErrorCode,
   SerializationException,
   clone,
@@ -58,6 +54,7 @@ import {
   excludePathValueFromTarget,
   getRecordEntry,
 } from '@microsoft/logic-apps-shared';
+import type { Segment, LocationSwapMap, LogicAppsV2, OperationManifest, SubGraphDetail } from '@microsoft/logic-apps-shared';
 import merge from 'lodash.merge';
 
 export interface SerializeOptions {

libs/designer/src/lib/core/actions/bjsworkflow/settings.ts

@@ -4,9 +4,8 @@ import { WorkflowKind } from '../../state/workflow/workflowInterfaces';
 import { getSplitOnOptions } from '../../utils/outputs';
 import { getTokenExpressionValue } from '../../utils/parameters/helper';
 import { TokenType } from '@microsoft/designer-ui';
-import type { SwaggerParser } from '@microsoft/logic-apps-shared';
-import { convertToStringLiteral, getSplitOnArrayAliasMetadata } from '@microsoft/logic-apps-shared';
 import type {
+  SwaggerParser,
   DownloadChunkMetadata,
   LogicApps,
   LogicAppsV2,
@@ -17,6 +16,8 @@ import type {
   UploadChunkMetadata,
 } from '@microsoft/logic-apps-shared';
 import {
+  convertToStringLiteral,
+  getSplitOnArrayAliasMetadata,
   equals,
   getObjectPropertyValue,
   getPropertyValue,

libs/designer/src/lib/core/parsers/BJSWorkflow/BJSDeserializer.ts

@@ -6,9 +6,8 @@ import { createWorkflowNode, createWorkflowEdge } from '../../utils/graph';
 import type { WorkflowNode, WorkflowEdge } from '../models/workflowNode';
 import { LoggerService, Status } from '@microsoft/designer-client-services-logic-apps';
 import { getDurationStringPanelMode } from '@microsoft/designer-ui';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import type { LogicAppsV2, SubgraphType } from '@microsoft/logic-apps-shared';
 import {
+  getIntl,
   containsIdTag,
   WORKFLOW_NODE_TYPES,
   WORKFLOW_EDGE_TYPES,
@@ -19,6 +18,7 @@ import {
   getUniqueName,
   getRecordEntry,
 } from '@microsoft/logic-apps-shared';
+import type { LogicAppsV2, SubgraphType } from '@microsoft/logic-apps-shared';
 
 const hasMultipleTriggers = (definition: LogicAppsV2.WorkflowDefinition): boolean => {
   return definition && definition.triggers ? Object.keys(definition.triggers).length > 1 : false;

libs/designer/src/lib/core/queries/connections.ts

@@ -1,8 +1,7 @@
 import { getReactQueryClient } from '../ReactQueryProvider';
 import { ConnectionService } from '@microsoft/designer-client-services-logic-apps';
-import { SwaggerParser } from '@microsoft/logic-apps-shared';
+import { SwaggerParser, equals } from '@microsoft/logic-apps-shared';
 import type { Connector } from '@microsoft/logic-apps-shared';
-import { equals } from '@microsoft/logic-apps-shared';
 import { useMemo } from 'react';
 import { useQuery } from 'react-query';
 

libs/designer/src/lib/core/queries/connector.ts

@@ -6,10 +6,8 @@ import type {
   TreeDynamicValue,
 } from '@microsoft/designer-client-services-logic-apps';
 import { ConnectorService } from '@microsoft/designer-client-services-logic-apps';
-import type { FilePickerInfo, LegacyDynamicSchemaExtension, LegacyDynamicValuesExtension } from '@microsoft/logic-apps-shared';
-import { Types } from '@microsoft/logic-apps-shared';
-import type { OpenAPIV2 } from '@microsoft/logic-apps-shared';
-import { getPropertyValue, equals, getJSONValue, getObjectPropertyValue, isNullOrUndefined } from '@microsoft/logic-apps-shared';
+import type { FilePickerInfo, LegacyDynamicSchemaExtension, LegacyDynamicValuesExtension, OpenAPIV2 } from '@microsoft/logic-apps-shared';
+import { Types, getPropertyValue, equals, getJSONValue, getObjectPropertyValue, isNullOrUndefined } from '@microsoft/logic-apps-shared';
 
 export const getLegacyDynamicValues = async (
   connectionId: string,

libs/designer/src/lib/core/state/selectors/actionMetadataSelector.ts

@@ -6,8 +6,7 @@ import { useConnector, useConnectorAndSwagger, useNodeConnectionId } from '../co
 import type { NodeOperation } from '../operation/operationMetadataSlice';
 import { OperationManifestService } from '@microsoft/designer-client-services-logic-apps';
 import type { LAOperation } from '@microsoft/logic-apps-shared';
-import { SwaggerParser } from '@microsoft/logic-apps-shared';
-import { getObjectPropertyValue, getRecordEntry } from '@microsoft/logic-apps-shared';
+import { SwaggerParser, getObjectPropertyValue, getRecordEntry } from '@microsoft/logic-apps-shared';
 import { createSelector } from '@reduxjs/toolkit';
 import { useMemo } from 'react';
 import { useQuery } from 'react-query';

libs/designer/src/lib/core/state/workflowparameters/workflowparametersSlice.ts

@@ -6,8 +6,7 @@ import { validateType } from '../../utils/validation';
 import { resetWorkflowState } from '../global';
 import type { WorkflowParameterUpdateEvent } from '@microsoft/designer-ui';
 import { UIConstants } from '@microsoft/designer-ui';
-import { getIntl } from '@microsoft/logic-apps-shared';
-import { equals, getRecordEntry, guid } from '@microsoft/logic-apps-shared';
+import { getIntl, equals, getRecordEntry, guid } from '@microsoft/logic-apps-shared';
 import { createSlice } from '@reduxjs/toolkit';
 import type { PayloadAction } from '@reduxjs/toolkit';