Skip to content

Commit

Permalink
fix(designer): Update Auth typo (#4700)
Browse files Browse the repository at this point in the history
* fix(designer): fix issue where scope nodes didn't get focused when they were jumped to

* small pr

* small fix

---------

Co-authored-by: Travis Harris <travisharris@microsoft.com>
  • Loading branch information
Eric-B-Wu and hartra344 committed Apr 25, 2024
1 parent ea76614 commit a1421e3
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
10 changes: 6 additions & 4 deletions Localize/lang/strings.json
Expand Up @@ -136,7 +136,6 @@
"3Y8a6G": "Required parameters {parameters} not set or invalid",
"3cZZKj": "Divider",
"3eeli7": "Select a source schema",
"3ewBbk": "The entered identity is not associated with this Logic App.",
"3n5pnv": "(UTC+10:30) Lord Howe Island",
"3n6GJG": "Enter a valid JSON.",
"3rzrWf": "Required. The object to remove the property from.",
Expand Down Expand Up @@ -247,6 +246,7 @@
"8DFwxH": "Returns a formatted number string",
"8FjOSh": "Required. The object to check if it is greater or equal to the comparing object.",
"8JEHiY": "Saturday",
"8KpZmj": "The system-assigned identity is unavailable because it's not enabled.",
"8L+oIz": "Cannot render designer due to multiple triggers in definition.",
"8LhQeL": "Switch to code view mode",
"8ND+Yc": "Please enable managed identity for the logic app.",
Expand Down Expand Up @@ -756,6 +756,7 @@
"UHCVNK": "Replaces a string with a given string",
"UIWX6p": "Logical Name",
"UMPuUJ": "Delete {expressionValue}",
"UPsZSw": "The entered identity is not associated with this logic app.",
"UR1CS5": "Hide code",
"USVffu": "Content not shown due to security configuration.",
"UT2ozj": "(UTC-07:00) Mountain Time (US & Canada)",
Expand Down Expand Up @@ -1045,7 +1046,6 @@
"_3Y8a6G.comment": "Error message to show when required parameters are not set or invalid",
"_3cZZKj.comment": "Aria label for divider",
"_3eeli7.comment": "Source schema dropdown placeholder",
"_3ewBbk.comment": "error message for invalid user",
"_3n5pnv.comment": "Time zone value ",
"_3n6GJG.comment": "Error validation message for Objects",
"_3rzrWf.comment": "Required object parameter to identify from which object to remove property from",
Expand Down Expand Up @@ -1156,6 +1156,7 @@
"_8DFwxH.comment": "Label for description of custom formatNumber Function",
"_8FjOSh.comment": "Required object parameter to check if greater than or equal to using greaterOrEqual function",
"_8JEHiY.comment": "Day of the week",
"_8KpZmj.comment": "error message for unsupported system-assigned managed identity",
"_8L+oIz.comment": "This is an error message shown when a user tries to load a workflow defintion that contains Multiple entry points which isn't supported",
"_8LhQeL.comment": "Label for editor toggle button when in expanded mode",
"_8ND+Yc.comment": "Error Message for disabled managed identity",
Expand Down Expand Up @@ -1665,6 +1666,7 @@
"_UHCVNK.comment": "Label for description of custom replace Function",
"_UIWX6p.comment": "Column header for connection reference logical name",
"_UMPuUJ.comment": "Label to delete a value",
"_UPsZSw.comment": "error message for invalid user",
"_UR1CS5.comment": "Button to hide the code view",
"_USVffu.comment": "Message text to inform the customer that the data is secure",
"_UT2ozj.comment": "Time zone value ",
Expand Down Expand Up @@ -2180,7 +2182,6 @@
"_pC2nr2.comment": "Placeholder text for Key",
"_pH2uak.comment": "Label to collapse",
"_pIczsS.comment": "Label text for request end time",
"_pM0Xl7.comment": "error message for unsupported System-assigned Managed Identity",
"_pMms92.comment": "Label for button to open dynamic content picker",
"_pOTcUO.comment": "Required object parameter to be converted to array using createArray function",
"_pOVDll.comment": "Error validation message for Integers",
Expand Down Expand Up @@ -2279,6 +2280,7 @@
"_tAbbH8.comment": "Title for a too many inputs card",
"_tAeKNh.comment": "Function display radio group option for simple",
"_tE7Zam.comment": "Label for description of custom listCallbackUrl Function",
"_tGSsgZ.comment": "Placehodler text for dropdown",
"_tH2pT1.comment": "Text for the Details page navigation heading",
"_tImHz/.comment": "This is a time duration in abbreviated format",
"_tLZ9Sh.comment": "Required number parameter to be used as index for multipartBody function",
Expand Down Expand Up @@ -2814,7 +2816,6 @@
"pC2nr2": "Enter key",
"pH2uak": "Collapse",
"pIczsS": "End time",
"pM0Xl7": "The system-assigned identity is unavailable because is is not enabled.",
"pMms92": "Insert Dynamic Content",
"pOTcUO": "Required. The values to combine into an array.",
"pOVDll": "Enter a valid integer.",
Expand Down Expand Up @@ -2913,6 +2914,7 @@
"tAbbH8": "Too many inputs assigned",
"tAeKNh": "Simple",
"tE7Zam": "Returns the URL to invoke the trigger or action",
"tGSsgZ": "select an identity",
"tH2pT1": "Return to search",
"tImHz/": "{days}d {hours}h",
"tLZ9Sh": "Required. The index of the part to retrieve.",
Expand Down
16 changes: 8 additions & 8 deletions libs/designer-ui/src/lib/authentication/MSIAuth/MSIAuth.tsx
Expand Up @@ -54,8 +54,8 @@ export const MSIAuthentication = ({ identity, msiProps, setCurrentProps, ...prop
description: 'Managed Identity Label',
});
const MSIAuthPlaceholder = intl.formatMessage({
defaultMessage: 'Please select an identity',
id: 'cgq/+y',
defaultMessage: 'select an identity',
id: 'tGSsgZ',
description: 'Placehodler text for dropdown',
});

Expand Down Expand Up @@ -102,8 +102,8 @@ const getManagedIdentityData = (
let errorMessage: string | undefined;

const invalidUserAssignedManagedIdentity = intl.formatMessage({
defaultMessage: 'The entered identity is not associated with this Logic App.',
id: '3ewBbk',
defaultMessage: 'The entered identity is not associated with this logic app.',
id: 'UPsZSw',
description: 'error message for invalid user',
});
const systemAssignedManagedIdentity = intl.formatMessage({
Expand All @@ -112,14 +112,14 @@ const getManagedIdentityData = (
description: 'Text for dropdown of system-assigned managed identity',
});
const systemIdentityNotSupported = intl.formatMessage({
defaultMessage: 'The system-assigned identity is unavailable because is is not enabled.',
id: 'pM0Xl7',
description: 'error message for unsupported System-assigned Managed Identity',
defaultMessage: "The system-assigned identity is unavailable because it's not enabled.",
id: '8KpZmj',
description: 'error message for unsupported system-assigned managed identity',
});
const userAssignedIdentities = containsUserAssignedIdentities(identity) ? getUserAssignedIdentities(identity) : undefined;
if (identity?.type) {
const supportedIdentityTypes = identity.type.split(',').map((identity) => identity.trim());
// determines which identities to supports based on the identity type
// determines which identities to support based on the identity type
const supportsUserAssignedIdentity = supportedIdentityTypes.some((type) => equals(type, ResourceIdentityType.USER_ASSIGNED));
const supportsSystemAssignedIdentity = supportedIdentityTypes.some((type) => equals(type, ResourceIdentityType.SYSTEM_ASSIGNED));

Expand Down

0 comments on commit a1421e3

Please sign in to comment.