Skip to content

Commit

Permalink
fix(designer): Fix stateless workflow check in getSplitOn (#4121)
Browse files Browse the repository at this point in the history
Fix stateless workflow check in `getSplitOn`
  • Loading branch information
ek68794998 committed Feb 5, 2024
1 parent 3373c32 commit b0d825d
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions libs/designer/src/lib/core/actions/bjsworkflow/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export const getOperationSettings = (
},
splitOn: {
isSupported: isSplitOnSupported(isTrigger, nodeOutputs, manifest, swagger, operationId, operation, workflowKind, forceEnableSplitOn),
value: getSplitOn(manifest, swagger, operationId, operation, workflowKind),
value: getSplitOn(manifest, swagger, operationId, operation, workflowKind, forceEnableSplitOn),
},
retryPolicy: {
isSupported: isRetryPolicySupported(isTrigger, operationInfo.type, manifest),
Expand All @@ -166,7 +166,7 @@ export const getOperationSettings = (
value: getSuppressWorkflowHeaders(isTrigger, nodeType, manifest, operation),
},
suppressWorkflowHeadersOnResponse: {
isSupported: isSuppressWorklowHeadersOnResponseSupported(isTrigger, manifest),
isSupported: isSuppressWorkflowHeadersOnResponseSupported(isTrigger, manifest),
value: getSuppressWorkflowHeadersOnResponse(operation),
},
concurrency: {
Expand Down Expand Up @@ -344,7 +344,7 @@ const getSuppressWorkflowHeadersOnResponse = (definition?: LogicAppsV2.Operation
return isOperationOptionSet(Constants.SETTINGS.OPERATION_OPTIONS.SUPPRESS_WORKFLOW_HEADERS_ON_RESPONSE, operationOptions);
};

const isSuppressWorklowHeadersOnResponseSupported = (isTrigger: boolean, manifest?: OperationManifest): boolean => {
const isSuppressWorkflowHeadersOnResponseSupported = (isTrigger: boolean, manifest?: OperationManifest): boolean => {
if (manifest) {
const operationOptionsSetting = getOperationSettingFromManifest(manifest, 'operationOptions') as
| OperationManifestSetting<OperationOptions[]>
Expand Down Expand Up @@ -517,9 +517,12 @@ const getSplitOn = (
swagger?: SwaggerParser,
operationId?: string,
definition?: LogicAppsV2.OperationDefinition,
workflowKind?: WorkflowKind
workflowKind?: WorkflowKind,
forceEnableSplitOn?: boolean
): SimpleSetting<string> => {
if (workflowKind === WorkflowKind.STATELESS) return { enabled: false };
if (workflowKind === WorkflowKind.STATELESS && !forceEnableSplitOn) {
return { enabled: false };
}
const splitOnValue = getSplitOnValue(manifest, swagger, operationId, definition);
return {
enabled: !!splitOnValue,
Expand Down

0 comments on commit b0d825d

Please sign in to comment.