Skip to content

Commit

Permalink
feat(Designer): Hide side panel when no node is selected and we are s…
Browse files Browse the repository at this point in the history
…uppressing default node click functionality (#4660)

* Empty panel is now hidden when we suppress default node select functionality

* Small bugfix

---------

Co-authored-by: Riley Evans <rileyevans@microsoft.com>
  • Loading branch information
rllyy97 and Riley Evans committed Apr 19, 2024
1 parent be01e89 commit b37c660
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions Localize/lang/strings.json
@@ -1,7 +1,6 @@
{
"++ZVe/": "Testing",
"+0H8Or": "Warning: input node type does not match the schema node's type",
"+0ua83": "Parameters",
"+0yxlR": "Function display",
"+3rROX": "Protected",
"+FcXe9": "Faulted",
Expand Down Expand Up @@ -907,11 +906,9 @@
"Zi9gQK": "Add new item",
"ZihyUf": "Close",
"ZkjTbp": "Learn more about dynamic content.",
"ZvAp7m": "Save",
"ZyDq4/": "Show a different suggestion",
"_++ZVe/.comment": "Title for testing section",
"_+0H8Or.comment": "Warning message for when input node type does not match schema node type",
"_+0ua83.comment": "Button text for parameters",
"_+0yxlR.comment": "Label for the function display radio group",
"_+3rROX.comment": "Label in the chatbot header stating that the users information is protected in this chatbot",
"_+FcXe9.comment": "The status message to show in monitoring view.",
Expand Down Expand Up @@ -1817,7 +1814,6 @@
"_Zi9gQK.comment": "Label to add item to property editor",
"_ZihyUf.comment": "Label for the close button in the chatbot header",
"_ZkjTbp.comment": "Text for dynamic content link",
"_ZvAp7m.comment": "Button text for save",
"_ZyDq4/.comment": "Text for the show different suggestion flow button",
"_a7j3gS.comment": "Required number parameter to divide in mod function",
"_aAXnqw.comment": "Required number of occurrences to get nthIndexOf function with",
Expand Down Expand Up @@ -2168,7 +2164,6 @@
"_oWGaw9.comment": "Click to view less token options.",
"_oZMhX/.comment": "Text of Tooltip to expand",
"_odQ554.comment": "Response body for test map API",
"_ohOaXj.comment": "Button text for errors",
"_onXUu0.comment": "Text to tell users to click to add comments",
"_osKNnl.comment": "Error validation message for doubles",
"_ox2Ou7.comment": "Placeholder for empty collapsed dictionary",
Expand Down Expand Up @@ -2252,7 +2247,6 @@
"_sEqLTV.comment": "An accessability label that describes the testing tab",
"_sFbnCs.comment": "Time zone value ",
"_sFwHQc.comment": "aria label description for cancel button",
"_sOnphB.comment": "Button text for resubmit",
"_sQ2vRs.comment": "add a case to switch statement",
"_sRpETS.comment": "Warning message for when custom value does not match schema node type",
"_sVQe34.comment": "The description for the test tab parameters.",
Expand Down Expand Up @@ -2801,7 +2795,6 @@
"oWGaw9": "See Less",
"oZMhX/": "Expand",
"odQ554": "Response body",
"ohOaXj": "Errors",
"onXUu0": "Add a note",
"osKNnl": "Enter a valid Double number.",
"ox2Ou7": "Enter a valid JSON",
Expand Down Expand Up @@ -2885,7 +2878,6 @@
"sEqLTV": "Testing Tab",
"sFbnCs": "(UTC-05:00) Chetumal",
"sFwHQc": "Cancel creating a connection",
"sOnphB": "Resubmit",
"sQ2vRs": "Add Case",
"sRpETS": "Warning: custom value does not match the schema node's type",
"sVQe34": "Provide parameters to test the output.",
Expand Down
2 changes: 1 addition & 1 deletion libs/designer-ui/src/lib/panel/panelheader/panelheader.tsx
Expand Up @@ -94,7 +94,7 @@ export const PanelHeader = ({
const isRight = headerLocation === PanelLocation.Right;

const noNodeOnCardLevel = noNodeSelected && panelScope === PanelScope.CardLevel;
const shouldHideCollapseButton = noNodeOnCardLevel && suppressDefaultNodeSelectFunctionality;
const shouldHideCollapseButton = isCollapsed && suppressDefaultNodeSelectFunctionality;

// collapsed -> loading -> connector icon -> error -> backup loading
const iconComponent = useMemo(
Expand Down

0 comments on commit b37c660

Please sign in to comment.