feat(designer): Add support for recommendation view to work without depending on prefetched data #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almaasrawi
changed the title
|
Discussion for reference: #3524 |
wifun
reviewed
Oct 25, 2023
libs/designer/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx
Outdated
Show resolved
Hide resolved
libs/designer/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx
Show resolved
Hide resolved
libs/designer/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx
Outdated
Show resolved
Hide resolved
rllyy97
reviewed
Oct 25, 2023
libs/designer/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx
Show resolved
Hide resolved
rllyy97
approved these changes
Oct 25, 2023
wifun
approved these changes
Oct 25, 2023
rllyy97
requested changes
Oct 25, 2023
libs/designer/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx
Outdated
Show resolved
Hide resolved
rllyy97
reviewed
Oct 25, 2023
libs/designer/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx
Outdated
Show resolved
Hide resolved
rllyy97
approved these changes
Oct 25, 2023
ek68794998
pushed a commit
that referenced
this pull request
Oct 25, 2023
…epending on prefetched data (#3525) * Add support for recommendation view to work without depending on prefetch data * Address PR comment from William * Address Riley's PR comment * remove extra 's' from const name
ek68794998
pushed a commit
that referenced
this pull request
Oct 25, 2023
…epending on prefetched data (#3525) * Add support for recommendation view to work without depending on prefetch data * Address PR comment from William * Address Riley's PR comment * remove extra 's' from const name
ek68794998
pushed a commit
that referenced
this pull request
Nov 2, 2023
…epending on prefetched data (#3525) * Add support for recommendation view to work without depending on prefetch data * Address PR comment from William * Address Riley's PR comment * remove extra 's' from const name
ek68794998
pushed a commit
that referenced
this pull request
Nov 9, 2023
…epending on prefetched data (#3525) * Add support for recommendation view to work without depending on prefetch data * Address PR comment from William * Address Riley's PR comment * remove extra 's' from const name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new methods in the search service to help the recommendation view work without relying on prefetched data. this includes:
getOperationByIdto help retrieve the operation by id upon click.getOperationsByConnectorto help retrieve the list of operations for a specific connector, when the connector header is clicked on from the browse or search views.The change has been smoke tested for Power Automate integration without returning any operation in the prefetch call, and completely relying on the new method callbacks.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Please Include Screenshots or Videos of the intended change:
AB#25597550