fix(designer): Fix regressions moving token parsing from $[ ]$ to @{} #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/setupPowerAutomate
…/setupPowerAutomate
rllyy97
approved these changes
Dec 19, 2023
hartra344
approved these changes
Dec 19, 2023
|
before: after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating a uniqueID, we've moved to use the token.value which is unique, which was done in this PR:
#3849
This should fix some of the regressions we've had
Also, instead of using loadParameterValueFromString from designer and supplying the tokenMapping in html editor, I've gone ahead and used the desinger-ui's stringToSegments function given that we have the nodeMap when transitioning between raw and rich html