Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Designer): fixed some scripts related to moving libs #4268

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix(Designer): fixed some scripts related to moving libs #4268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0bb156
updated scripts and fixed test helpers
DanielleCogs Feb 28, 2024
37c8806
fixed yalc output location for logic-apps-shared
DanielleCogs Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/production-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,9 @@ jobs:
[
{ dist: './dist/libs/data-mapper', package: 'data-mapper' },
{ dist: './dist/libs/designer', package: 'designer' },
{ dist: './dist/libs/utils', package: 'utils' },
{ dist: './dist/libs/designer-ui', package: 'designer-ui' },
{ dist: './dist/libs/services/designer-client-services', package: 'services-designer-client-services' },
{ dist: './dist/libs/logic-apps-shared', package: 'logic-apps-shared' },
{ dist: './dist/libs/services/intl', package: 'services-intl' },
{ dist: './dist/libs/vscode-extension', package: 'vscode-extension' },
{ dist: './dist/libs/chatbot', package: 'chatbot' },
]
Expand Down
10 changes: 1 addition & 9 deletions .versionrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@
"filename": "libs/designer-ui/package.json",
"type": "json"
},
{
"filename": "libs/utils/package.json",
"type": "json"
},
{
"filename": "libs/services/intl/package.json",
"type": "json"
},
{
"filename": "apps/vs-code-designer/src/package.json",
"type": "json"
Expand All @@ -31,7 +23,7 @@
"type": "json"
},
{
"filename": "libs/parsers/package.json",
"filename": "libs/logic-apps-shared/package.json",
"type": "json"
},
{
Expand Down
2 changes: 1 addition & 1 deletion libs/data-mapper/src/lib/__test__/intl-test-helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* These helper functions aim to address that and wrap a valid,
* English-locale intl context around them.
*/
import messages from '../../../../../lib/services/intl/src/compiled-lang/strings.json';
import messages from '../../../../../libs/logic-apps-shared/src/intl/src/compiled-lang/strings.json';
import { createIntl, createIntlCache } from 'react-intl';
import * as Intl from 'react-intl';

Expand Down
2 changes: 1 addition & 1 deletion libs/designer-ui/src/lib/__test__/intl-test-helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* English-locale intl context around them.
*/
// eslint-disable-next-line @nrwl/nx/enforce-module-boundaries
import messages from '../../../../services/intl/src/compiled-lang/strings.json';
import messages from '../../../../logic-apps-shared/src/intl/src/compiled-lang/strings.json';
import { createIntl, createIntlCache } from 'react-intl';
import * as Intl from 'react-intl';

Expand Down
2 changes: 1 addition & 1 deletion libs/designer/src/lib/__test__/intl-test-helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* These helper functions aim to address that and wrap a valid,
* English-locale intl context around them.
*/
import messages from '../../../../../lib/services/intl/src/compiled-lang/strings.json';
import messages from '../../../../../libs/logic-apps-shared/src/intl/src/compiled-lang/strings.json';
import { createIntl, createIntlCache } from 'react-intl';
import * as Intl from 'react-intl';

Expand Down
4 changes: 2 additions & 2 deletions libs/logic-apps-shared/jest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable */
export default {
displayName: 'parsers',
displayName: 'shared',
preset: '../../jest.preset.js',
setupFilesAfterEnv: ['./jest.setup.js'],
transform: {
Expand All @@ -25,5 +25,5 @@ export default {
'@fluentui/react/lib/(.*)$': '@fluentui/react/lib-commonjs/$1',
},
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'],
coverageDirectory: '../../coverage/libs/parsers',
coverageDirectory: '../../coverage/libs/logic-apps-shared',
};
2 changes: 1 addition & 1 deletion libs/logic-apps-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"name": "@microsoft/logic-apps-shared",
"version": "2.116.0",
"scripts": {
"yalcpush": "yalc push ../../../dist/libs/logic-apps-shared"
"yalcpush": "yalc push ../../dist/libs/logic-apps-shared"
}
}
Loading