Feat(Data Mapper): Able to save data map #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleCogs
force-pushed
the
danielle/dm-save
branch
from
2d9886a
to
c21dc6c
Compare
takyyon
approved these changes
Jun 10, 2024
| return new DataMapperFileService(sendMsgToVsix); | ||
| } , [sendMsgToVsix]); | ||
|
|
||
| // const addSchemaFromFile = (selectedSchemaFile: SchemaFile) => { |
There was a problem hiding this comment.
can we please remove all the commented-out code from the PR? We can use this PR if we need to reference that code again?
There was a problem hiding this comment.
I feel like we're already missing out on code that we already have functionality for, so idk about this. Let's discuss during our dev sync?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
none
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Created new service to manage calls that go to vscode and interact with the file system
this prevents us from passing functions down multiple components to be called
Data Mapper is able to be loaded into VSCode, with limited functionality
Connections saved in the store and save using save button
no