Make New-ASCVASolution script compatible with Azure PowerShell module 5.x #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaal
requested review from
dicolanl,
tarosler,
TomJanetscheck and
YuriDio
as code owners
|
|
rwaal
changed the title
elSagie
approved these changes
Jan 31, 2021
TomJanetscheck
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
New-ASCVASolution.ps1is incompatible with the Azure PowerShellAzmodule version 5 and higher (or module Az.Accounts version 2.2.0 and higher).A breaking change was introduced in the Az module v5.0.0 that doesn't allow the access token to be retrieved using the
Get-AzCachedAccessToken()function. The Az module now has a built-in cmdlet for retrieving the access token:Get-AzAccessToken.This PR adds the following:
Get-AzCachedAccessTokenfunction with the built-in cmdletGet-AzAccessToken.In the Notes section I updated to version 2.0.0. My update is a breaking change, therefore I found it appropriate to bump to the next major version number.