Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Apache configuration #12

Closed
2 tasks done
SorraTheOrc opened this issue Jan 19, 2018 · 3 comments
Closed
2 tasks done

Improvements to Apache configuration #12

SorraTheOrc opened this issue Jan 19, 2018 · 3 comments
Labels
enhancement New feature or request Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves.

Comments

@SorraTheOrc
Copy link
Contributor

SorraTheOrc commented Jan 19, 2018

PR #10 added the ability to choose Apache or NGinx as the server, In the PR comments the following two ToDo items were noted:

  • Redirect direct outside Apache http connection (to port 81) to https (443)
  • Log correct IP address instead of 127.0.0.1 for Apache http (nginx http does that already)
@SorraTheOrc SorraTheOrc added enhancement New feature or request Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves. labels Jan 19, 2018
@hosungsmsft
Copy link

#18 implements these two. Closing this with that.

@SorraTheOrc
Copy link
Contributor Author

SorraTheOrc commented Jan 26, 2018 via email

@hosungsmsft
Copy link

Ah, right... It's been a while since I actively developed on GitHub, and I just forgot that. Will use that in the future. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves.
Projects
None yet
Development

No branches or pull requests

2 participants