Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modest updates to shell script files #99

Closed
wants to merge 9 commits into from

Conversation

CatalystAUInf
Copy link
Contributor

Moved more common code from install_moodle and setup_webserver to helper_functions.sh

Copy link

@hosungsmsft hosungsmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no changes in this PR at all, because all commits are just reverted in the commit set. Please do discard those reverted commits by rebasing and add the actual commits so that we can actually start reviewing your work. Thanks!

@@ -0,0 +1,510 @@
# Custom Script for Linux for Mahara/Azure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR adding a Mahara script. This repo is for Moodle and so this seems out of place. Was this accidentally committed or is there an objective here. If so what issue does this relate to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, appears to have been added incidentally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) easily done. You may be interested in an open issue to separate out the LAMP deployment parts of this template so that it will be reusable across different LAMP applications. See #101

@CatalystAUInf
Copy link
Contributor Author

Closing this PR, it looks like some of the things I have altered have been already done, resulting in too many conflicts when rebasing, will create a new branch based on the latest Azure/Moodle and push the results.

@SorraTheOrc
Copy link
Contributor

This PR is a WIP for #79

@CatalystAUInf
Copy link
Contributor Author

This PR has ended up with too many large conflicts when rebasing. I think it better to create new one with all latest changes as I think my initial branch was out of date.

@hosungsmsft
Copy link

@CatalystAUInf -- Please note that other Catalyst folks have been using a new fork: https://github.com/catalyst/azure_moodle. I think you might want to use the same? Just a guess. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants