Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RULE] Migrate to App Gateway WAF policy #2877

Closed
BernieWhite opened this issue May 21, 2024 · 1 comment · Fixed by #2881
Closed

[RULE] Migrate to App Gateway WAF policy #2877

BernieWhite opened this issue May 21, 2024 · 1 comment · Fixed by #2881
Assignees
@BenjaminEngeset
Labels
good first issue Good for newcomers help wanted Extra attention is needed pillar: reliability Aligned to the Reliability pillar. rule: app-gateway Rules for App Gateway
Milestone
v1.37.0

Comments

@BernieWhite
Copy link
Collaborator

Existing rule

No response

Suggested rule

App Gateway V2 supports two configuration modes for WAF:

  1. Reference an existing WAF policy reference via properties.firewallPolicy.id.
  2. Specify the WAF configuration via setting the properties.webApplicationFirewallConfiguration. This option is deprecated for retirement on 15 March 2027.

The rule should identify cases when properties.webApplicationFirewallConfiguration is configured and provide a recommendation to use a WAF policy instead.

Pillar

Reliability

Additional context
@BernieWhite BernieWhite added pillar: reliability Aligned to the Reliability pillar. rule: app-gateway Rules for App Gateway help wanted Extra attention is needed good first issue Good for newcomers labels May 21, 2024
@BenjaminEngeset
Copy link
Contributor

:shipit:

@BenjaminEngeset BenjaminEngeset mentioned this issue May 22, 2024
Merged
11 tasks
@BernieWhite BernieWhite added this to the v1.37.0 milestone May 22, 2024
@BernieWhite BernieWhite mentioned this issue May 24, 2024
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue Jun 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminEngeset BenjaminEngeset

Labels
good first issue Good for newcomers help wanted Extra attention is needed pillar: reliability Aligned to the Reliability pillar. rule: app-gateway Rules for App Gateway
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging a pull request may close this issue.

feat(new): Added Azure.AppGw.MigrateWAFPolicy BenjaminEngeset/PSRule.Rules.Azure
2 participants
@BernieWhite @BenjaminEngeset