Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use identity-based authentication for App Configuration #1693

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

pazdedav
Copy link
Contributor

@pazdedav pazdedav commented Sep 21, 2022

PR Summary

New rule created to disable local authN (keys, SAS tokens) to Azure App Configuration and favor Azure AD authN instead:

  • Azure.AppConfig.DisableLocalAuth.md docs page created
  • New rule added to Azure.AppConfig.Rule.yaml
  • New test section added to Azure.AppConfig.Tests.ps1
  • Test template Resources.AppConfig.json updated, so one of the configStores passes, another fails

Fixes #1691

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@pazdedav pazdedav marked this pull request as ready for review September 21, 2022 18:17
@pazdedav pazdedav requested a review from a team as a code owner September 21, 2022 18:17
Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pazdedav Awesome work! All good to merge.

@pazdedav pazdedav merged commit 42926ba into Azure:main Sep 22, 2022
@pazdedav pazdedav deleted the pazdedav/issue1691 branch September 22, 2022 06:48
@BernieWhite BernieWhite added the ms-hack-2022 Issues related to Microsoft Global Hackathon 2022 label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ms-hack-2022 Issues related to Microsoft Global Hackathon 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable cryptographic keys for App Configuration stores
2 participants