Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure.VNET.UseNSGs reason message #256 #257 #258

Merged
merged 1 commit into from Jan 16, 2020
Merged

Fix Azure.VNET.UseNSGs reason message #256 #257 #258

merged 1 commit into from Jan 16, 2020

Conversation

BernieWhite
Copy link
Collaborator

PR Summary

Fixes #256
Fixes #257

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BernieWhite BernieWhite merged commit 001a280 into master Jan 16, 2020
@BernieWhite BernieWhite deleted the bewhite/fix-subnet-nsg-reason branch January 16, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reason strings to use parent culture Azure.VNET.UseNSGs not populating subnet name in reason message
1 participant
@BernieWhite