Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated alert, from using Azure AD to Microsoft Entra ID. #2789

Merged
merged 4 commits into from Apr 1, 2024

Conversation

lukemurraynz
Copy link
Contributor

PR Summary

I updated the alert to use Microsoft Entra ID instead of Azure Active Directory for CosmosDB.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

Still a few references to docs.microsoft.com.

Even though this works, its a redirect, and could potentially break in the future.

Cleaning up links, to point to learn.microsoft.com directly.
Updated alert, from using Azure AD to Microsoft Entra ID.
@lukemurraynz lukemurraynz requested a review from a team as a code owner March 31, 2024 04:53
Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukemurraynz. All good to merge.

@BernieWhite BernieWhite merged commit ae831d0 into Azure:main Apr 1, 2024
13 checks passed
@BernieWhite BernieWhite mentioned this pull request Apr 14, 2024
4 tasks
@BernieWhite BernieWhite mentioned this pull request Apr 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants