rds-update-certificate script.ps1 fix issue #12 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
mmarch
suggested changes
May 15, 2017
| @@ -38,7 +38,7 @@ $ConfigData = @{ | |||
| } # End of Config Data | |||
|
|
|||
| $Logfile = ".\CB_PostConfig1.1_{0}.log" -f (get-date -Format "yyyyMMddhhmmss") | |||
| � | |||
| � | |||
| � | ||
| �� Add-content $Logfile -value $logstring | ||
| �� Write-Host $logstring | ||
| �� Param ([string]$logstring) |
There was a problem hiding this comment.
what are these funny characters, what IDE are you using
make sure indentation and spacing consistent with the rest of the file
| @@ -24,7 +24,7 @@ param | |||
| ) | |||
|
|
|||
| $localhost = [System.Net.Dns]::GetHostByName((hostname)).HostName | |||
| $domainNetbios = (Get-ADDomain -Current LocalComputer).NetBIOSName | |||
| $domainNetbios = (Get-WmiObject Win32_NTDomain -Filter "DnsForestName = '$((Get-WmiObject Win32_ComputerSystem).Domain)'").DomainName | |||
There was a problem hiding this comment.
I left a comment on #17: there is no intent to support WS2012,
the two supported versions are WS12R2 and WS16 where this cmdlet is available. so not an issue, and no fix required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #12 rds-update-certificate script.ps1 azurerm always installing