Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Enable Publishing to always publish if no version was found in the target location #2153

Closed
AlexanderSehr opened this issue Sep 30, 2022 · 2 comments · Fixed by #2410
Assignees
Labels
[cat] publishing category: publishing enhancement New feature or request

Comments

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Sep 30, 2022

Description

Currently, a module is only published if git detects code changes for a module when comparing with Head^-1.

This can lead to some undesired behavior if you set up CARML for the first time, directly in main, and run the pipelines without any module changes. If that's the case, you won't be able to publish unless you apply a workaround such as a modification of the version.json file.

To mitigate this behavior we could add some logic to the publishing to the dedicated target locations (i.e., ACR, Template Specs, Universal Packages) that not only checks for changes, but also if there is already a version in that target location. If there is none, the pipeline could then decide to publish even if there are no module changes.

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] publishing category: publishing labels Sep 30, 2022
@eriqua
Copy link
Contributor

eriqua commented Sep 30, 2022

Also as a separate issue, but related to the last point above, we should restrict the comparison logic which triggers the publishing to ignore changes to readme and test files as those should not impact the module version.

@AlexanderSehr AlexanderSehr changed the title [Feature Request]: Enable Publishing to always publish if not version was found in the target location [Feature Request]: Enable Publishing to always publish if no version was found in the target location Sep 30, 2022
@AlexanderSehr AlexanderSehr self-assigned this Dec 2, 2022
@AlexanderSehr AlexanderSehr changed the title [Feature Request]: Enable Publishing to always publish if no version was found in the target location [Feature Request]: Enable Publishing to always publish if no version was found in the target location & compare the hashes if there is Dec 2, 2022
@AlexanderSehr AlexanderSehr changed the title [Feature Request]: Enable Publishing to always publish if no version was found in the target location & compare the hashes if there is [Feature Request]: Enable Publishing to always publish if no version was found in the target location Dec 2, 2022
@AlexanderSehr
Copy link
Contributor Author

AlexanderSehr commented Dec 2, 2022

Linked to #2401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] publishing category: publishing enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants