Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: module for vm should allow setting tags on extensions #3115

Closed
davidkarlsen opened this issue Apr 18, 2023 · 0 comments · Fixed by #3116
Closed

[Feature Request]: module for vm should allow setting tags on extensions #3115

davidkarlsen opened this issue Apr 18, 2023 · 0 comments · Fixed by #3116
Assignees
@davidkarlsen
Labels
[cat] modules category: modules enhancement New feature or request

Comments

@davidkarlsen
Copy link
Contributor

Description

https://github.com/Azure/ResourceModules/blob/main/modules/Microsoft.Compute/virtualMachines/extensions/deploy.bicep#L57 vs https://learn.microsoft.com/en-us/azure/templates/microsoft.compute/virtualmachines/extensions?pivots=deployment-language-bicep#resource-format
it should be possible to pass tags to the extensions, as our policy does not allow for untagged resources - thus the VM deployment fails if I attempt to use any extensions.
@davidkarlsen davidkarlsen added the enhancement New feature or request label Apr 18, 2023
davidkarlsen pushed a commit to davidkarlsen/ResourceModules that referenced this issue Apr 18, 2023
add tags on extensions. Fixes Azure#3115
7ed2fac 
Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
davidkarlsen pushed a commit to davidkarlsen/ResourceModules that referenced this issue Apr 18, 2023
add tags on extensions. Fixes Azure#3115
9a59813 
Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Apr 18, 2023
@AlexanderSehr AlexanderSehr linked a pull request Apr 18, 2023 that will close this issue
[Modules] Add tags on VM extensions. Fixes #3115 #3116
Merged
8 tasks
eriqua pushed a commit that referenced this issue Apr 19, 2023
@davidkarlsen
[Modules] Add tags on VM extensions. Fixes #3115 (#3116)
5cd7068 
* add tags on extensions. Fixes #3115

Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>

* pass on tags to child deployments too

Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>

---------

Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
Co-authored-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
@eriqua eriqua mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidkarlsen davidkarlsen

Labels
[cat] modules category: modules enhancement New feature or request
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Modules] Add tags on VM extensions. Fixes #3115 davidkarlsen/ResourceModules
2 participants
@davidkarlsen @AlexanderSehr