Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for publishing json templates using ADO #1003

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Feb 14, 2022

Change

Based on an issue raised by Eliza via mail.

There is a copy/paste mistake in the ADO publishing template, causing an issue when attempting to resolve a template path when using json templates.

For testing:

  • Created a new branch of this branch (users/mast/publishingfixADOjsonValidation)
  • Converted whole repo to be ARM/Json
  • Only running publishing on the following pipelines
  • It successfully runs the pipelines

Build Status

Build Status

Build Status

Build Status

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this Feb 14, 2022
@MariusStorhaug MariusStorhaug changed the title Bugfix for publishing json using ado Bugfix for publishing json templates using ADO Feb 14, 2022
@MariusStorhaug MariusStorhaug linked an issue Feb 14, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug merged commit 0819b0c into main Feb 16, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/publishingfixADOjson branch February 16, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when publishing json templates using ADO
2 participants