Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN Site: Created new module #1088

Merged
merged 9 commits into from Mar 5, 2022
Merged

VPN Site: Created new module #1088

merged 9 commits into from Mar 5, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Mar 5, 2022 •
edited

Change

  • Created new VPN Site module (to get it out of the vWan module)
  • Added pipelines & readmes
  • Updated a test to give better feedback

Pipeline reference: IaCS

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Mar 5, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Mar 5, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.5 milestone Mar 5, 2022
@AlexanderSehr AlexanderSehr linked an issue Mar 5, 2022 that may be closed by this pull request
vWAN: Move modules out of vWAN #982
Closed
AlexanderSehr and others added 3 commits March 5, 2022 22:34
@AlexanderSehr
Update arm/Microsoft.Network/vpnSites/.parameters/parameters.json
4814c3f 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Network/virtualHubs/deploy.bicep
7d94743 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Network/vpnSites/.parameters/min.parameters.json
3931796 
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@MariusStorhaug MariusStorhaug merged commit 80287c5 into main Mar 5, 2022
@MariusStorhaug MariusStorhaug deleted the users/alsehr/982_vpnSite branch March 5, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vWAN: Move modules out of vWAN
2 participants
@AlexanderSehr @MariusStorhaug