Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Aligned the CMK implementation across current modules #1589

Merged
merged 14 commits into from
Jul 5, 2022
Merged

[Modules] Aligned the CMK implementation across current modules #1589

merged 14 commits into from
Jul 5, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jun 24, 2022 •
edited

Description

  • Updated AutomationAccount implementation
  • Updaed Batch implementation
  • Updated Registries implementation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Automation: AutomationAccounts
Batch: BatchAccounts
ContainerRegistry: Registries

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jun 24, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft June 24, 2022 20:40
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 24, 2022
@AlexanderSehr AlexanderSehr linked an issue Jun 24, 2022 that may be closed by this pull request
[Feature Request]: Align Customer-Managed-Key implementations (CMK) accross modules as much as possible #1484
Closed
@github-actions
Copy link

github-actions bot commented Jun 25, 2022 •
edited

Unit Test Results

  1 files    1 suites   16s ⏱️
53 tests 53 ✔️ 0 💤 0 ❌
55 runs  55 ✔️ 0 💤 0 ❌

Results for commit f8499ac.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 25, 2022 08:46
@AlexanderSehr AlexanderSehr marked this pull request as draft June 27, 2022 15:50
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 27, 2022 17:26
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner June 30, 2022 06:08
eriqua
eriqua approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 6b94237 into main Jul 5, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1484_cmkAlignment branch July 5, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Align Customer-Managed-Key implementations (CMK) accross modules as much as possible
2 participants
@AlexanderSehr @eriqua