Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes] Fixed incorrect param file ref #1626

Merged
merged 1 commit into from
Jun 30, 2022
Merged

[Fixes] Fixed incorrect param file ref #1626

merged 1 commit into from
Jun 30, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jun 30, 2022 •
edited

Description

  • Fixed incorrect param file ref

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 30, 2022 06:00
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner June 30, 2022 06:00
@AlexanderSehr AlexanderSehr merged commit f7eabf6 into main Jun 30, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/pesterTypoFix branch June 30, 2022 06:02
AlexanderSehr added a commit that referenced this pull request Jun 30, 2022
@AlexanderSehr
[Utilities] Updated ReadMe Utility to handle bicep test files when ge…
0dca935 
…nerating deployment examples (#1628)

* Update to latest

* Fixed incorrect param file ref (#1626)

* Further updates

* Further updates

* Updated tool

* Upper case title update
AlexanderSehr added a commit that referenced this pull request Aug 29, 2022
@AlexanderSehr
[CI Environment] Enabled CI environment to handle DeploymentTest (bic…
6bb70a5 
…ep) files for new self-contained dependency approach (#1624)

* added missing address space

* Fix param ref

* Further refactoring

* Update to latest

* Update to latest

* Fixed deployment ref

* Update to latest

* Updated GH piplines + minor improvements

* Fixed ref

* another try

* Another try

* Fixed GH pipeline

* Updated names

* Rename

* Stardted refactoring the readme function

* Renamed var

* Update modules/.global/global.module.tests.ps1

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update to latest

* Renamed variable

* Further updates

* [Utilities] Updated ReadMe Utility to handle bicep test files when generating deployment examples (#1628)

* Update to latest

* Fixed incorrect param file ref (#1626)

* Further updates

* Further updates

* Updated tool

* Upper case title update

* Commenting

* Formatting update

* Added order

* Added support for ARM deployment test file

* Updated handling of ARM-JSON deployment files + updated tests

* Update to latest

* Small updates

* Small updates

* Added documentation

* Added docs

* Update to latest

* Regenerated docs

* Added config exception

* Added config exception

* Mergef first couple changes from PR 1632

* Merged first batch of set-moduleReadMe script updates (not yet compatible with bicep-json)

* Latest draft including bicep to json intermediate format

* Further improvements when dealing with classic parameter files

* Updated function & tested arm converted test file

* Updated comments

* Added SQL server example & updated readme robustness

* Added SQL server example & updated readme robustness

* Updated pipeline

* Added additional error handling

* Fixed dpeloyment test

* Updated docs

* Adjusted publishing

* Adjusted var syntax

* Added initial draft for virtualHub

* Updated readme

* Minor updates

* Updated readmes

* Improved robustness

* Renamed folder

* Adjusted output

* Removed redundant dependency

* Regenerated docs

* Updated Set-ModuleReadMe with Bicep support & regenerated docs

* Updated Set-ModuleReadMe with Bicep support & regenerated docs

* Updated comments

* Updated robustness

* Updated robustness

* Updated docs

* Another update

* Changed casing

* Added error handling

* Added error handling

* Adjusted naming

* Refactored ADO dependency pipeline

* Refactored ADO dependency pipeline

* Renamed parameter

* Added var

* Test replace

* Test replace

* Test replace

* Test replace

* Test replace

* Attempt to parameterize parameter fetch for ADO

* Adjusted references

* Small fix

* Adjusted references

* Added var

* Added parameter file case handling

* Fixed condition

* Fixed ref

* Rename

* Added copied dependency pipeline template

* Simplified pipelines

* Minor refactoring

* Removed modulePath param from dependency pipeline

* Cleanup

* Cleanup

* Updated naming

* Update jobs.validateModuleDeployment.yml

* Cleanup

* Update to latest

* Restructured folders

* Updated test to new dependency folder structure

* Removed nameprefix from parameter

* Merged latest main

* Update readmes

* Update to latest

* Update to latest

* Changed namePrefix param to token

* Removed namePrefix param leftovers

* Changed comments

* Adjust case hanlding

* Adjusted name prefix handling

* Added output

* Update to latest

* Disabled pester

* Update to latest

* Refactored file handling

* Fallback

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Removed namePrefix param

* Minor fix

* Added VM draft

* Improved case handling

* Updated readme

* Cleanup

* Update to latest

* Fixed Pester test

* Update to latest

* Update to latest

* Small fix

* Another small fix for linux

* Fixed ref

* Merged latest main

* Another small fix

* Update to latest

* Update to latest

* Update to latest

* Merged latest

* Added small upgrade to mgmtgroup removal + cleanup of  pipeline

* Update to latest

* Fixed sa name

* Renamed res

* Updated removal

* added commment

* Update to latest

* Adjusted conditions

* Update to latest

* Update to latest

* Update to latest

* Updated ReadMe

* Simplified names & updated readmes

* Renamed RG

* Fixed VM dependencies

* Naming update

* Updated VM dependencies

* Updated docs

* Added missing role assignment

* Small bracket fix

* RoleAssignment fix

* Further fixes

* Further fixes

* Further fixes

* Further fixes

* Sync

* Fixed folder ref

* Adjuted lb

* Update to latest

* Update to latest

* Update to latest

* Added missing pipeline flag

* Adjusted output

* Added docs for new dependencies approach

* Small update

* Fixed name

* Update to latest

* Reenabled param json compatibility

* Updated SQL server api

* Update to latest

* Several fixes

* Update to latest

* Update to latest

* Adjusted cond

* Fixed removal

* Added key rbac + small renames

* small renames

* Template fix

* Updated cse

* Update naming

* Removed reworked modules from PR

* Update to latest

* Update to latest

* Update to latest

* Small readmeGen fix + improved readability

* Updated AutomationAccount

* Small update

* Update to latest

* Update to latest

* Small regex update

* typoe

* Added missing quote

* Update Initialize-DeploymentRemoval.ps1

Ensured that key vault is removed before resource group to ensure purge

* Update Invoke-ResourcePostRemoval.ps1

Added KeyVault purge for purge protected key vaults

* Update .azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update .azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update .azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update .github/actions/templates/validateModuleDeployment/action.yml

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update .github/actions/templates/validateModuleDeployment/action.yml

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update docs/wiki/The CI environment - Static validation.md

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update docs/wiki/The library - Module design.md

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update docs/wiki/The library - Module design.md

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>

* Update to latest

* Update to latest

* Update to latest

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexanderSehr @ahmadabdalla