Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Policy assignment updated nonCompliance messages #1644

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Jul 7, 2022

Description

Closes #1643 and #1625

Updates the policy assignment module to change the nonComplianceMessage to plural and set it to an array as per the documentation

++ added exemptions on the .lycheeignore file to remove false positives.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Authorization: PolicyAssignments

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla requested a review from a team as a code owner July 7, 2022 05:49
@ahmadabdalla ahmadabdalla self-assigned this Jul 7, 2022
@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Jul 7, 2022
@eriqua eriqua changed the title updated policy assignment nonCompliance messages [Modules] Policy assignment updated nonCompliance messages Jul 7, 2022
.lycheeignore Show resolved Hide resolved
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit fa8d770 into main Jul 8, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/policyAssignmentUpdate branch July 8, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Policy Assignment 'NonComplianceMessages' property is string instead of array
2 participants