Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Role Assignment output #1649

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jul 7, 2022

Description

  • Fixing role assignment output metadata description
  • Renaming role definition output parameter

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Authorization: RoleAssignments

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua requested a review from a team as a code owner July 7, 2022 16:29
@eriqua eriqua added bug Something isn't working [cat] modules category: modules labels Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Unit Test Results

    1 files  ±    0      1 suites  ±0   26s ⏱️ -39s
141 tests  - 259  133 ✔️  - 259  8 💤 ±0  0 ±0 
146 runs   - 255  138 ✔️  - 255  8 💤 ±0  0 ±0 

Results for commit 93e0c63. ± Comparison against base commit 013bc47.

Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pickup 👍🏼

@ahmadabdalla ahmadabdalla merged commit f2fef8c into main Jul 7, 2022
@ahmadabdalla ahmadabdalla deleted the users/erikag/fix-roleassignment-output branch July 7, 2022 22:15
@eriqua eriqua linked an issue Jul 9, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Role assignment output metadata description is flipped
2 participants