Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Batch accounts: Add private endpoint support with updated parameters file. #1654

Merged
merged 15 commits into from
Jul 8, 2022
Merged

[Modules] Batch accounts: Add private endpoint support with updated parameters file. #1654

merged 15 commits into from
Jul 8, 2022

Conversation

ishita-malik1
Copy link
Contributor

Description

Add private endpoint support with updated parameters file to Batch account module.
Part of the fix for #890

Pipeline references

Pipeline
Batch: BatchAccounts

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ghost
Copy link

ghost commented Jul 8, 2022 •
edited by ghost

CLA assistant check
All CLA requirements met.

@ishita-malik1 ishita-malik1 marked this pull request as ready for review July 8, 2022 12:40
@ishita-malik1 ishita-malik1 requested a review from a team as a code owner July 8, 2022 12:40
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Jul 8, 2022
eriqua
eriqua approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit 531271f into Azure:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@ishita-malik1 ishita-malik1

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ishita-malik1 @eriqua @kavishshivhare @kavish-shivhare