Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Environment] Added test case for parameter description #1687

Merged
merged 4 commits into from
Jul 21, 2022
Merged

[CI Environment] Added test case for parameter description #1687

merged 4 commits into from
Jul 21, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jul 17, 2022 •
edited

Description

  • Added a test to ensure no non-required parameter (no default) has a description that starts with 'Required'.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 17, 2022 21:51
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] testing category: testing labels Jul 17, 2022
@AlexanderSehr AlexanderSehr linked an issue Jul 17, 2022 that may be closed by this pull request
Check optional vs required parameter description Feature Request #1034
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 17, 2022 21:51
AlexanderSehr and others added 2 commits July 21, 2022 18:23
@AlexanderSehr @eriqua
Update utilities/pipelines/staticValidation/module.tests.ps1
4380c17 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update utilities/pipelines/staticValidation/module.tests.ps1
2df5658 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
eriqua approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗️

@AlexanderSehr AlexanderSehr merged commit 280db1a into main Jul 21, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1034_optionalTest branch July 21, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] testing category: testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check optional vs required parameter description Feature Request
2 participants
@AlexanderSehr @eriqua