Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Configure privateDnsZoneGroups on storage account #1690

Merged
merged 6 commits into from
Jul 18, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jul 18, 2022

Description

Closes #1671

  • Adding private DNS zone group id to associate the private endpoint with a private DNS zone.
  • Updating publicNetworkAccess implementation to be disabled by default only if:
    • no explicit value is passed
    • private endpoint parameter is not empty
    • network acls parameter is empty
      This is needed to allow both private endpoint and firewall rules to be applied on the same resource (i.e. set network access to selected networks only)
  • Updating main test to deploy both pe and network acls
  • Updating encr test to deploy also pe alone.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua requested a review from a team as a code owner July 18, 2022 12:21
@eriqua eriqua enabled auto-merge (squash) July 18, 2022 12:21
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Jul 18, 2022
@eriqua eriqua merged commit 1974983 into main Jul 18, 2022
@eriqua eriqua deleted the 1671-storage-pe branch July 18, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
2 participants