Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Configure privateDnsZoneGroups on servicebus and networking restructuring #1700

Merged
merged 27 commits into from
Jul 20, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jul 20, 2022

Description

Closes #1698

  • Adding private DNS zone group id to associate the private endpoint with a private DNS zone.
  • Updating API version
  • Removing IpFilterRules and virtualNetworkRules outdated resource types in favor of the recently introduced networkRuleSets.
    • Updating tests and readmes to reflect the change
    • Cleaning up custom resource removal not needed anymore
  • Updating main test to deploy both pe and network rules (to test that public network access stays enabled).
  • Adding pe test to deploy pe alone (to test that public network access gets disabled).
  • Adding new test to ADO
  • Minor formatting alignments

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ServiceBus: Namespaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Jul 20, 2022
@eriqua eriqua requested a review from a team as a code owner July 20, 2022 09:51
@github-actions
Copy link

github-actions bot commented Jul 20, 2022

Unit Test Results

    1 files  ±0      1 suites  ±0   55s ⏱️ +3s
330 tests +4  325 ✔️ +5  5 💤  - 1  0 ±0 
332 runs  +6  327 ✔️ +7  5 💤  - 1  0 ±0 

Results for commit a9143fd. ± Comparison against base commit 8bfcec9.

♻️ This comment has been updated with latest results.

@eriqua eriqua enabled auto-merge (squash) July 20, 2022 10:00
@eriqua eriqua merged commit d6fd348 into main Jul 20, 2022
@eriqua eriqua deleted the users/erikag/1698-servicebus-pe branch July 20, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure privateDnsZoneGroups on servicebus (namespace - privatelink.servicebus.windows.net)
2 participants