Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Update VM domainJoin parameter usage #1711

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Conversation

jriekse5555
Copy link
Contributor

@jriekse5555 jriekse5555 commented Jul 23, 2022

Readme PR per request by Rainer Halanek PR related to bug I submitted (#1595). Updated the domain join settings to the correct ones to domain join correctly. The previous ones in the readme do not work and would attempt to join a blank workgroup. Reference: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/join-windows-vm-template

Description

Thank you for your contribution !

Please include a summary of the change and which issue is fixed.
Please also include the context.
List any dependencies that are required for this change.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Readme PR per request by Rainer Halanek PR related to bug I submitted (Azure#1595). Updated the domain join settings to the correct ones to domain join correctly. The previous ones in the readme do not work and would attempt to join a blank workgroup. Reference: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/join-windows-vm-template
@jriekse5555 jriekse5555 requested a review from a team as a code owner July 23, 2022 23:22
@eriqua eriqua changed the title Update readme.md [Fixes] Update VM domainJoin parameter usage Jul 23, 2022
@eriqua eriqua added documentation Improvements or additions to documentation enhancement New feature or request [cat] modules category: modules labels Jul 23, 2022
…aram to match readme change

In response to @ahmadabdalla 's request in the PR review. Module param description updated to reflect change in readme to correct domain join settings.
Updated same changes in domain join setting parameters as in vm readme. Also changed parameter description in readme
Updated the readme parameter description to match the changes.
Updated parameter description for extensionDomainJoinPassword to match changes
Description for parameter updated to match changes in readme
@ahmadabdalla ahmadabdalla added blocked if an issue is blocked and removed blocked if an issue is blocked labels Jul 29, 2022
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jriekse5555

@eriqua eriqua merged commit 31dedb3 into Azure:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Microsoft.Compute\virtualMachines\readme.md does not have correct syntax for joining a domain
3 participants