Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Fixing ADO removal for role assignments #1746

Merged
merged 3 commits into from
Aug 3, 2022
Merged

[Fixes] Fixing ADO removal for role assignments #1746

merged 3 commits into from
Aug 3, 2022

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Aug 3, 2022

Fixing resource removal issue in Azure DevOps

Addressing issue #1745

Module pipelines are failing in certain situations:

  • when the module needs more than one iteration to remove all related resources
  • when the previous removal iteration contained a role assignment, the next iteration fails
  • can be reproduced on Azure DevOps only, when using Azure DevOps Repos. I was not able to reproduce it with GitHub Actions and with Azure DevOps with a GitHub Repository
  • multiple modules are affected, for example KeyVault, Compute Galleries and many more.

Pipeline references

Pipeline
Build Status

Adding a screenshot as the pipeline is in a private DevOps project:
image

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@krbar krbar requested a review from a team as a code owner August 3, 2022 20:22
@eriqua eriqua added bug Something isn't working [cat] testing category: testing labels Aug 3, 2022
@eriqua eriqua changed the title Users/krbar/removal fix [Fixes] Fixing ADO removal for role assignments Aug 3, 2022
@eriqua eriqua enabled auto-merge (squash) August 3, 2022 20:27
@eriqua eriqua linked an issue Aug 3, 2022 that may be closed by this pull request
@eriqua eriqua merged commit 88ef838 into Azure:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] testing category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Resource Removal fails with wrong Hashtable input error
3 participants