Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update App config tests #1758

Merged
merged 8 commits into from
Aug 6, 2022
Merged

[Modules] Update App config tests #1758

merged 8 commits into from
Aug 6, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Aug 6, 2022

Description

Adding a specific test for private endpoints. Using them with public network access disabled does not allow to create/access keyValues child resource from the GH runner.
Tested idempotency by deploying the module twice, skipping removal the first time.
Also updated condition to disable public network access if pe are set. Not needed for this resource since it's done by the service automatically.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AppConfiguration: ConfigurationStores

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Aug 6, 2022
@eriqua eriqua requested a review from a team as a code owner August 6, 2022 00:15
@eriqua eriqua enabled auto-merge (squash) August 6, 2022 00:20
@eriqua eriqua merged commit ecbdc18 into main Aug 6, 2022
@eriqua eriqua deleted the users/erikag/appconfig branch August 6, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants