Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Introduced several linter-ignore statements for false-positives #1770

Merged
merged 6 commits into from
Sep 1, 2022
Merged

[Modules] Introduced several linter-ignore statements for false-positives #1770

merged 6 commits into from
Sep 1, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 9, 2022 •
edited

Description

  • Introduced several linter-ignore statements for false-positives -> Parameters are flagged because they 'may' me a secret (and should have the @secure annotation), even if they are not.
  • Otherwise, these would be surfaced as warnings when building the template

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 9, 2022 07:36
@AlexanderSehr AlexanderSehr self-assigned this Aug 9, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 9, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 9, 2022 07:36
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 15, 2022
Merged
4 tasks
eriqua
eriqua approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit fca10d1 into main Sep 1, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/handleSecureLinter branch September 1, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexanderSehr @eriqua