Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules]: Azure Database for PostgreSQL Flexible Servers Module #1779

Merged
merged 17 commits into from
Aug 16, 2022

Conversation

ahmadabdalla
Copy link
Contributor

Description

Closes #1751

  • Enabled the PostgreSQL - Flexible Server Module

  • Added a new dependency vnet and a private dns zone for the module.

  • Contains 3 child modules (configurations, firewallrules, databases)

  • Contains 3 scenarios for parameter file testing to cover all parameter combinations

NOTE: The nature of the of this resource type 'may' sometimes fail when adding the 'configurations', especially when having more than one in the array. This is not a CARML issue. The error returned is 'InternalServerError'. However, after performing multiple tests. The likelihood of this happening is small. I suggested initially whether we should remove this parameter from being tested, but I prefer to have it. Our pipelines retry 3 times for a deployment and that seems to be sufficient

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DbForPostgreSQL: FlexibleServers

image

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added the [cat] modules category: modules label Aug 12, 2022
@ahmadabdalla ahmadabdalla added this to the Release 0.7 milestone Aug 12, 2022
@ahmadabdalla ahmadabdalla self-assigned this Aug 12, 2022
@ahmadabdalla ahmadabdalla added this to Ready for review in Backlog via automation Aug 12, 2022
@ahmadabdalla ahmadabdalla marked this pull request as ready for review August 13, 2022 21:38
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner August 13, 2022 21:38
@ahmadabdalla ahmadabdalla marked this pull request as draft August 13, 2022 22:30
@ahmadabdalla ahmadabdalla marked this pull request as ready for review August 15, 2022 10:34
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) August 16, 2022 21:53
@ahmadabdalla ahmadabdalla merged commit 9665a0c into main Aug 16, 2022
Backlog automation moved this from Ready for review to Done Aug 16, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/postgres branch August 16, 2022 21:54
@AlexanderSehr AlexanderSehr changed the title [Module]: Azure Database for PostgreSQL Flexible Servers Module [Modules]: Azure Database for PostgreSQL Flexible Servers Module Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Develop Microsoft Database for PostgreSQL Module
2 participants