-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules]: Azure Database for PostgreSQL Flexible Servers Module #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/Microsoft.DBforPostgreSQL/flexibleServers/.bicep/nested_roleAssignments.bicep
Show resolved
Hide resolved
modules/Microsoft.DBforPostgreSQL/flexibleServers/configurations/deploy.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
approved these changes
Aug 16, 2022
AlexanderSehr
changed the title
[Module]: Azure Database for PostgreSQL Flexible Servers Module
[Modules]: Azure Database for PostgreSQL Flexible Servers Module
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1751
Enabled the PostgreSQL - Flexible Server Module
Added a new dependency vnet and a private dns zone for the module.
Contains 3 child modules (configurations, firewallrules, databases)
Contains 3 scenarios for parameter file testing to cover all parameter combinations
NOTE: The nature of the of this resource type 'may' sometimes fail when adding the 'configurations', especially when having more than one in the array. This is not a CARML issue. The error returned is 'InternalServerError'. However, after performing multiple tests. The likelihood of this happening is small. I suggested initially whether we should remove this parameter from being tested, but I prefer to have it. Our pipelines retry 3 times for a deployment and that seems to be sufficient
Pipeline references
Type of Change
Checklist