Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules #1789

Merged
merged 2 commits into from
Aug 26, 2022
Merged

[Modules] Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules #1789

merged 2 commits into from
Aug 26, 2022

Conversation

DanielLarsenNZ
Copy link
Contributor

@DanielLarsenNZ DanielLarsenNZ commented Aug 17, 2022 •
edited

Description

Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules. This output is required for Bicep templates that deploy Azure Front Door or App Gateway with App Services, Functions and Static Websites.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@DanielLarsenNZ DanielLarsenNZ requested a review from a team as a code owner August 17, 2022 04:21
@DanielLarsenNZ
Copy link
Contributor Author

Fixes #1788

ahmadabdalla
ahmadabdalla requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :) I provided some comments regarding the documentation

modules/Microsoft.Web/sites/readme.md Outdated Show resolved Hide resolved
modules/Microsoft.Web/staticSites/readme.md Outdated Show resolved Hide resolved
@AlexanderSehr AlexanderSehr changed the title Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules [Modules] Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules Aug 17, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 17, 2022
@AlexanderSehr AlexanderSehr merged commit b3efda6 into Azure:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@DanielLarsenNZ DanielLarsenNZ

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielLarsenNZ @ahmadabdalla @AlexanderSehr