Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules]: Bug fix for Automation account using uniqueString() instead of newGuid() for the job schedule name #1794

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

ahmadabdalla
Copy link
Contributor

Description

Closes #1792

Recent change from the newGuid() to the uniqueString() function does not generate a new GUID for the job schedule child resource. More details is described in the issue.

Pipeline references

Pipeline
Automation: AutomationAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Aug 19, 2022
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner August 19, 2022 04:54
@ahmadabdalla ahmadabdalla added this to Ready for review in Backlog via automation Aug 19, 2022
@ahmadabdalla ahmadabdalla self-assigned this Aug 19, 2022
@ahmadabdalla
Copy link
Contributor Author

This PR should support #1790

@ahmadabdalla ahmadabdalla merged commit 9b316e8 into main Aug 19, 2022
Backlog automation moved this from Ready for review to Done Aug 19, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/1792_automation branch August 19, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Automation Account module failing on one of the test files due to the jobSchedule property
2 participants