Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Corrected Private Endpoint Parameter Usage documentation #1805

Merged
merged 2 commits into from
Aug 27, 2022

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Aug 27, 2022

Closes #1802

Description

This PR updates the primary readme section for referencing a private endpoint parameter usage. After that regenerated all documentations to ensure we update them with the guidance fix.

See issue for more details.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AppConfiguration: ConfigurationStores
Automation: AutomationAccounts
Batch: BatchAccounts
Cache: Redis
EventGrid: Topics
EventHub: Namespaces
Insights: PrivateLinkScopes
ServiceBus: Namespaces
Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla self-assigned this Aug 27, 2022
@github-actions
Copy link

github-actions bot commented Aug 27, 2022

Unit Test Results

    1 files      1 suites   2m 49s ⏱️
447 tests 442 ✔️ 5 💤 0
451 runs  446 ✔️ 5 💤 0

Results for commit 45e7944.

♻️ This comment has been updated with latest results.

@ahmadabdalla ahmadabdalla added bug Something isn't working documentation Improvements or additions to documentation [cat] modules category: modules labels Aug 27, 2022
@ahmadabdalla ahmadabdalla marked this pull request as ready for review August 27, 2022 01:03
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner August 27, 2022 01:03
@ahmadabdalla ahmadabdalla merged commit ff84378 into main Aug 27, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/bugFix_privateDnsZoneResourceIds branch August 27, 2022 20:09
@eriqua eriqua changed the title [Bug Fix] Corrected Private Endpoint Parameter Usage documentation [Fixes] Corrected Private Endpoint Parameter Usage documentation Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules documentation Improvements or additions to documentation
Projects
None yet
2 participants