Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Environment] Several general improvements #1808

Merged
merged 7 commits into from
Sep 1, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 30, 2022

Description

  • Removed outdated test & fixed error message format
  • Minor improvement to Set-ModuleReadMeScript for titles
  • Minor improvements for Release generation to reduce false-positive findings of regex
  • Better documentation of template output

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 30, 2022 17:27
@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 30, 2022 17:28
@ahmadabdalla
Copy link
Contributor

ahmadabdalla commented Aug 30, 2022

@MrMCake not related to this branch but picked it up when reviewing this PR.. but something has changed recently (also on main), where I'm getting the below changes to a readme file when attempting to test the modules locally on Linux:

image

I reran the same on my fork, which is about (11 days ~ 16 commits) ago. Thought of raising this in case you are not across it

auto-merge was automatically disabled August 31, 2022 05:32

Pull request was closed

@AlexanderSehr AlexanderSehr reopened this Aug 31, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 31, 2022 05:39
@AlexanderSehr
Copy link
Contributor Author

@MrMCake not related to this branch but picked it up when reviewing this PR.. but something has changed recently (also on main), where I'm getting the below changes to a readme file when attempting to test the modules locally on Linux:

image

I reran the same on my fork, which is about (11 days ~ 16 commits) ago. Thought of raising this in case you are not across it

I'll double check that. Maybe I can make it more explicit. The added "to Title Case" should help but maybe it must be in more places.

@ahmadabdalla
Copy link
Contributor

I'll double check that. Maybe I can make it more explicit. The added "to Title Case" should help but maybe it must be in more places.

@MrMCake its actually on Windows too.

@AlexanderSehr AlexanderSehr merged commit b3e9f27 into main Sep 1, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/minorDepImprov branch September 1, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] pipelines category: pipelines [cat] testing category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants