Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Authorization/policyDefinitions to new dependency approach #1813

Merged
merged 12 commits into from
Oct 24, 2022
Merged

[Modules] Updated Authorization/policyDefinitions to new dependency approach #1813

merged 12 commits into from
Oct 24, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated Authorization/policyDefinitions to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Authorization: PolicyDefinitions

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr linked an issue Aug 30, 2022 that may be closed by this pull request
[Feature Request]: Re-work modules to new dependency approach #1791
Closed
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited

Unit Test Results

    1 files      1 suites   1m 11s ⏱️
119 tests 110 ✔️   9 💤 0 ❌
140 runs  128 ✔️ 12 💤 0 ❌

Results for commit ff5da4d.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@AlexanderSehr AlexanderSehr removed a link to an issue Sep 5, 2022
[Feature Request]: Re-work modules to new dependency approach #1791
Closed
@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Authorization/policyDefinitions to new dependencies approach #1910
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 19:01
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 19:01
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 19:01
@ahmadabdalla ahmadabdalla self-requested a review October 11, 2022 09:34
@ahmadabdalla
Copy link
Contributor

Pending change to the implementation approach:
MicrosoftTeams-image

@AlexanderSehr
Copy link
Contributor Author

Pending change to the implementation approach: MicrosoftTeams-image

As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able to properly handle this alternative approach. A larger refactoring may be required.

ahmadabdalla
ahmadabdalla reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex. Minor suggestion on the serviceShort name, and please change the folder name to .common for MG and SUB.

modules/Microsoft.Authorization/policyDefinitions/.test/mg/deploy.test.bicep Outdated Show resolved Hide resolved
modules/Microsoft.Authorization/policyDefinitions/.test/sub/deploy.test.bicep Outdated Show resolved Hide resolved
@AlexanderSehr AlexanderSehr merged commit 57fd3d2 into main Oct 24, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Authorization_PolicyDefinitions branch October 24, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Authorization/policyDefinitions to new dependencies approach
2 participants
@AlexanderSehr @ahmadabdalla