Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated Automation/AutomationAccounts to new dependency approach #1818

Merged
merged 18 commits into from
Oct 13, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated Automation/AutomationAccounts to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Automation: AutomationAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Unit Test Results

    1 files  ±    0      1 suites  ±0   2m 12s ⏱️ +33s
279 tests +111  272 ✔️ +107  7 💤 +4  0 ±0 
296 runs  +111  287 ✔️ +107  9 💤 +4  0 ±0 

Results for commit 343478c. ± Comparison against base commit 7d115fd.

This pull request removes 168 and adds 279 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/accessPolicies] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [vaults/keys] should use one of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [vaults/secrets] should use one of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/jobSchedules] used resource type [automationAccounts/jobSchedules] should use one of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/modules] used resource type [automationAccounts/modules] should use one of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/runbooks] used resource type [automationAccounts/runbooks] should use one of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/schedules] used resource type [automationAccounts/schedules] should use one of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/softwareUpdateConfigurations] used resource type [automationAccounts/softwareUpdateConfigurations] should use one of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/variables] used resource type [automationAccounts/variables] should use one of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/jobSchedules] should use one of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/modules] should use one of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/runbooks] should use one of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/schedules] should use one of the recent API version(s). Currently using [2020-01-13-preview]
…
This pull request removes 3 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KeyVault/vaults/keys] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.KeyVault/vaults/secrets] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.KeyVault/vaults] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Automation/automationAccounts/jobSchedules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Automation/automationAccounts/modules] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Automation/automationAccounts/modules] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Automation/automationAccounts/modules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Automation/automationAccounts/schedules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Automation/automationAccounts/variables] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Automation/automationAccounts] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 9, 2022 that may be closed by this pull request
AlexanderSehr and others added 3 commits October 10, 2022 20:33
…eploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 10, 2022 19:26
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner October 10, 2022 19:26
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 10, 2022 19:26
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 405b115 into main Oct 13, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Automation_AutomationAccounts branch October 13, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Automation/automationAccounts to new dependencies approach
2 participants