Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Compute/VirtualMachines to new dependency approach #1822

Merged
merged 20 commits into from
Oct 19, 2022
Merged

[Modules] Updated Compute/VirtualMachines to new dependency approach #1822

merged 20 commits into from
Oct 19, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated Compute/VirtualMachines to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited

Unit Test Results

    1 files      1 suites   2m 1s ⏱️
100 tests   98 ✔️ 2 💤 0 ❌
150 runs  143 ✔️ 7 💤 0 ❌

Results for commit fb13c30.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Compute/virtualMachines to new dependencies approach #1919
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 18:25
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 18:25
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 18:25
@eriqua eriqua added [prio] high importance of the issue: high priority and removed [prio] high importance of the issue: high priority labels Sep 29, 2022
@AlexanderSehr AlexanderSehr merged commit 317cdde into main Oct 19, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Compute_VirtualMachines branch October 19, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahalan rahalan rahalan approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Compute/virtualMachines to new dependencies approach
3 participants
@AlexanderSehr @rahalan @eriqua